From 4bae3237464889454cff9cbdec7bd7ba61d3dccd Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Mon, 23 Oct 2023 18:43:36 -0600 Subject: [PATCH] mb/prodrive/hermes: Skip NULL check after setting up struct By calling get_board_settings() when board_cfg is initialized, board_cfg is guaranteed not to be NULL, so don't check to see if it's NULL. Found-by: Coverity Scan #1513079 Signed-off-by: Martin Roth Change-Id: I61105be9ed71ff30efdda66d2cbfcaf54d70053f Reviewed-on: https://review.coreboot.org/c/coreboot/+/78618 Tested-by: build bot (Jenkins) Reviewed-by: Marshall Dawson --- src/mainboard/prodrive/hermes/romstage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/prodrive/hermes/romstage.c b/src/mainboard/prodrive/hermes/romstage.c index a479bd51af..a3028c2dfd 100644 --- a/src/mainboard/prodrive/hermes/romstage.c +++ b/src/mainboard/prodrive/hermes/romstage.c @@ -83,7 +83,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd) cannonlake_memcfg_init(&memupd->FspmConfig, &baseboard_mem_cfg); /* Tell FSP-M about the desired primary video adapter so that GGC is set up properly */ - if (board_cfg && board_cfg->primary_video == PRIMARY_VIDEO_INTEL) + if (board_cfg->primary_video == PRIMARY_VIDEO_INTEL) memupd->FspmConfig.PrimaryDisplay = 0; /* iGPU is primary */ /* Overwrite memupd */