GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/espi_util: simplify espi_std_io_decode function 

We can just return at all places where the ret variable was written
before its value gets returned at the end of the function.

Change-Id: Id87f41c0d9e3397879ac3d15b13179cca1a1263f
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44350
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Felix Held 2020-08-10 20:33:25 +02:00
parent f08fbf882a
commit 4bf419fbf7
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/soc/amd/common/block/lpc/espi_util.c
View File

@ -104,29 +104,21 @@ static int espi_get_unused_io_window(void)
*/
static int espi_std_io_decode(uint16_t base, size_t size)
{
int ret = -1;
if (size != 1)
return ret;
return -1;
switch (base) {
case 0x80:
ret = ESPI_DECODE_IO_0x80_EN;
break;
return ESPI_DECODE_IO_0x80_EN;
case 0x60:
case 0x64:
ret = ESPI_DECODE_IO_0X60_0X64_EN;
break;
return ESPI_DECODE_IO_0X60_0X64_EN;
case 0x2e:
case 0x2f:
ret = ESPI_DECODE_IO_0X2E_0X2F_EN;
break;
return ESPI_DECODE_IO_0X2E_0X2F_EN;
default:
ret = -1;
break;
return -1;
}
return ret;
}
static size_t espi_get_io_window_size(int idx)