Do not allow modifying memory table directly
Adding ranges directly into coreboot memory table raised issues as those methods bypassed the MTRR setup. Such regions are now added as resources, so declare the functions again as static. Change-Id: If78613da40eabc5c99c49dbe2d6047cb22a71b69 Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com> Reviewed-on: http://review.coreboot.org/1415 Reviewed-by: Alexandru Gagniuc <mr.nuke.me@gmail.com> Tested-by: build bot (Jenkins)
This commit is contained in:
parent
cf8e466084
commit
4c29d7f27d
|
@ -338,7 +338,7 @@ static struct lb_forward *lb_forward(struct lb_header *header, struct lb_header
|
|||
}
|
||||
#endif
|
||||
|
||||
void lb_memory_range(struct lb_memory *mem,
|
||||
static void lb_memory_range(struct lb_memory *mem,
|
||||
uint32_t type, uint64_t start, uint64_t size)
|
||||
{
|
||||
int entries;
|
||||
|
@ -503,8 +503,7 @@ static void lb_remove_memory_range(struct lb_memory *mem,
|
|||
}
|
||||
}
|
||||
|
||||
/* This function is used in mainboard specific code, too */
|
||||
void lb_add_memory_range(struct lb_memory *mem,
|
||||
static void lb_add_memory_range(struct lb_memory *mem,
|
||||
uint32_t type, uint64_t start, uint64_t size)
|
||||
{
|
||||
lb_remove_memory_range(mem, start, size);
|
||||
|
|
|
@ -8,9 +8,6 @@ unsigned long write_coreboot_table(
|
|||
unsigned long low_table_start, unsigned long low_table_end,
|
||||
unsigned long rom_table_start, unsigned long rom_table_end);
|
||||
|
||||
void lb_memory_range(struct lb_memory *mem,
|
||||
uint32_t type, uint64_t start, uint64_t size);
|
||||
|
||||
/* Routines to extract part so the coreboot table or information
|
||||
* from the coreboot table.
|
||||
*/
|
||||
|
|
|
@ -4,9 +4,6 @@
|
|||
#include <boot/coreboot_tables.h>
|
||||
#include <arch/coreboot_tables.h>
|
||||
|
||||
void lb_add_memory_range(struct lb_memory *mem,
|
||||
uint32_t type, uint64_t start, uint64_t size);
|
||||
|
||||
struct lb_memory *write_tables(void);
|
||||
|
||||
#endif /* BOOT_TABLES_H */
|
||||
|
|
Loading…
Reference in New Issue