From 4c7349cf85e744a60977f11104b9be4d43c46bc7 Mon Sep 17 00:00:00 2001 From: Richard Spiegel Date: Thu, 23 Aug 2018 13:46:34 -0700 Subject: [PATCH] vendorcode/amd/pi/00670F00/Lib/AmdLib.c: Remove IdsErrorStop Function IdsErrorStop() is only used within AmdLib.c function LibAmdMsrRead(), which in turn is only used once within PspBaseLib.c and three times inside AmdLib.c, all with well defined MSR addresses. IdsErrorStop() is used as a trap if MSR address is 0 or 0xFFFFFFFF, which clearly it's not. Therefore it can be safely removed from AmdLib.c. BUG=b:112885948 TEST=Build grunt Change-Id: I47ffcbd4fbae28b6d711a340f0ac3f3b007e8e4f Signed-off-by: Richard Spiegel Reviewed-on: https://review.coreboot.org/28295 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Marshall Dawson --- src/vendorcode/amd/pi/00670F00/Lib/amdlib.c | 27 --------------------- 1 file changed, 27 deletions(-) diff --git a/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c b/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c index b03beee287..8a4113f9b2 100644 --- a/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c +++ b/src/vendorcode/amd/pi/00670F00/Lib/amdlib.c @@ -266,9 +266,6 @@ LibAmdMsrRead ( IN OUT AMD_CONFIG_PARAMS *ConfigPtr ) { - if ((MsrAddress == 0xFFFFFFFF) || (MsrAddress == 0x00000000)) { - IdsErrorStop(MsrAddress); - } *Value = __readmsr (MsrAddress); } @@ -574,27 +571,3 @@ GetPciMmioAddress ( } return MmioIsEnabled; } - -BOOLEAN -IdsErrorStop ( - IN UINT32 FileCode - ) -{ - struct POST { - UINT16 deadlo; - UINT32 messagelo; - UINT16 deadhi; - UINT32 messagehi; - } post = {0xDEAD, FileCode, 0xDEAD, FileCode}; - UINT16 offset = 0; - UINT16 j; - - while(1) { - offset %= sizeof(struct POST) / 2; - WriteIo16(80, *((UINT16 *)&post)+offset); - ++offset; - for (j=0; j<250; ++j) { - ReadIo8(80); - } - } -}