GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge: Rename `discover_edges` functions 

These are simply read MPR training, using the MPR pattern mode in MR3.

Change-Id: Icdc60572e0ee0b59dcb5dee1e1aceccfda79f029
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47610
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Angel Pons 2020-11-14 01:26:52 +01:00
parent a93f46ebc0
commit 4c79f93082
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/northbridge/intel/sandybridge/raminit_common.c
View File

@ -2308,7 +2308,7 @@ int command_training(ramctr_timing *ctrl)
return 0; return 0;
} }
static int discover_edges_real(ramctr_timing *ctrl, int channel, int slotrank, int *edges) static int find_read_mpr_margin(ramctr_timing *ctrl, int channel, int slotrank, int *edges)
{ {
int edge; int edge;
int stats[NUM_LANES][MAX_EDGE_TIMING + 1]; int stats[NUM_LANES][MAX_EDGE_TIMING + 1];
@ -2412,7 +2412,7 @@ static void find_predefined_pattern(ramctr_timing *ctrl, const int channel)
} }
} }
int discover_edges(ramctr_timing *ctrl) int read_mpr_training(ramctr_timing *ctrl)
{ {
int falling_edges[NUM_CHANNELS][NUM_SLOTRANKS][NUM_LANES]; int falling_edges[NUM_CHANNELS][NUM_SLOTRANKS][NUM_LANES];
int rising_edges[NUM_CHANNELS][NUM_SLOTRANKS][NUM_LANES]; int rising_edges[NUM_CHANNELS][NUM_SLOTRANKS][NUM_LANES];
@ -2441,7 +2441,7 @@ int discover_edges(ramctr_timing *ctrl)
printram("discover falling edges:\n[%x] = %x\n", IOSAV_DC_MASK, 0x300); printram("discover falling edges:\n[%x] = %x\n", IOSAV_DC_MASK, 0x300);
FOR_ALL_CHANNELS FOR_ALL_POPULATED_RANKS { FOR_ALL_CHANNELS FOR_ALL_POPULATED_RANKS {
err = discover_edges_real(ctrl, channel, slotrank, err = find_read_mpr_margin(ctrl, channel, slotrank,
falling_edges[channel][slotrank]); falling_edges[channel][slotrank]);
if (err) if (err)
return err; return err;
@ -2451,7 +2451,7 @@ int discover_edges(ramctr_timing *ctrl)
printram("discover rising edges:\n[%x] = %x\n", IOSAV_DC_MASK, 0x200); printram("discover rising edges:\n[%x] = %x\n", IOSAV_DC_MASK, 0x200);
FOR_ALL_CHANNELS FOR_ALL_POPULATED_RANKS { FOR_ALL_CHANNELS FOR_ALL_POPULATED_RANKS {
err = discover_edges_real(ctrl, channel, slotrank, err = find_read_mpr_margin(ctrl, channel, slotrank,
rising_edges[channel][slotrank]); rising_edges[channel][slotrank]);
if (err) if (err)
return err; return err;

2
src/northbridge/intel/sandybridge/raminit_common.h
View File

@ -259,7 +259,7 @@ void dram_jedecreset(ramctr_timing *ctrl);
int read_training(ramctr_timing *ctrl); int read_training(ramctr_timing *ctrl);
int write_training(ramctr_timing *ctrl); int write_training(ramctr_timing *ctrl);
int command_training(ramctr_timing *ctrl); int command_training(ramctr_timing *ctrl);
int discover_edges(ramctr_timing *ctrl); int read_mpr_training(ramctr_timing *ctrl);
int discover_edges_write(ramctr_timing *ctrl); int discover_edges_write(ramctr_timing *ctrl);
int discover_timC_write(ramctr_timing *ctrl); int discover_timC_write(ramctr_timing *ctrl);
void normalize_training(ramctr_timing *ctrl); void normalize_training(ramctr_timing *ctrl);

2
src/northbridge/intel/sandybridge/raminit_native.c
View File

@ -690,7 +690,7 @@ int try_init_dram_ddr3(ramctr_timing *ctrl, int fast_boot, int s3resume, int me_
printram("CP5a\n"); printram("CP5a\n");
err = discover_edges(ctrl); err = read_mpr_training(ctrl);
if (err) if (err)
return err; return err;