GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/poppy/variants/nocturne: remove icc_max overrides 

Remove icc_max overrides to allow SoC code to set proper
icc_max based on CPU SKU.

BUG=b:78122599
BRANCH=none
TEST='emerge-nocturne coreboot chromeos-bootimage', flash to
nocturne, boot to kernel and verify device doesn't hang after
a few minutes.

Change-Id: I37c44e2428b802d754f2b12b8a57601d257e6582
Signed-off-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-on: https://review.coreboot.org/27996
Reviewed-by: Caveh Jalali <caveh@google.com>
Reviewed-by: Lijian Zhao <lijian.zhao@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nick Vaccaro 2018-08-09 16:05:15 -07:00 committed by Patrick Georgi
parent 2dd7b6b2f9
commit 4cb8ac234b
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/poppy/variants/nocturne/devicetree.cb
View File

@ -87,7 +87,7 @@ chip soc/intel/skylake
#| Psi4Enable | 1 | 1 | 1 | 1 | #| Psi4Enable | 1 | 1 | 1 | 1 |
#| ImonSlope | 0 | 0 | 0 | 0 | #| ImonSlope | 0 | 0 | 0 | 0 |
#| ImonOffset | 0 | 0 | 0 | 0 | #| ImonOffset | 0 | 0 | 0 | 0 |
#| IccMax | 4A | 28A | 24A | 24A | #| IccMax | Set by SoC code per CPU SKU |
#| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V | #| VrVoltageLimit | 1.52V | 1.52V | 1.52V | 1.52V |
#| AcLoadline | 14.9 | 4 | 5.7 | 4.57 | #| AcLoadline | 14.9 | 4 | 5.7 | 4.57 |
#| DcLoadline | 14.2 | 4 | 4.2 | 4.3 | #| DcLoadline | 14.2 | 4 | 4.2 | 4.3 |
@ -101,7 +101,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(4),
.voltage_limit = 1520, .voltage_limit = 1520,
.ac_loadline = 1490, .ac_loadline = 1490,
.dc_loadline = 1420, .dc_loadline = 1420,
@ -116,7 +115,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(28),
.voltage_limit = 1520, .voltage_limit = 1520,
.ac_loadline = 400, .ac_loadline = 400,
.dc_loadline = 400, .dc_loadline = 400,
@ -131,7 +129,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(24),
.voltage_limit = 1520, .voltage_limit = 1520,
.ac_loadline = 570, .ac_loadline = 570,
.dc_loadline = 420, .dc_loadline = 420,
@ -146,7 +143,6 @@ chip soc/intel/skylake
.psi4enable = 1, .psi4enable = 1,
.imon_slope = 0x0, .imon_slope = 0x0,
.imon_offset = 0x0, .imon_offset = 0x0,
.icc_max = VR_CFG_AMP(24),
.voltage_limit = 1520, .voltage_limit = 1520,
.ac_loadline = 457, .ac_loadline = 457,
.dc_loadline = 430, .dc_loadline = 430,