From 4ccbd49617d9c2f9e51900367c20dcc840735906 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 28 May 2021 13:35:41 -0500 Subject: [PATCH] ec/purism/librem/ec.asl: Disable notification for touchpad enable/disable Somehow, enabling the notification to the OS driver breaks the functionality it was meant to enable. Until this can be resolved, disable the driver notification, so that the key functions as intended. Test: build/boot librem_bdw and librem_skl boards, verify trackpad enable toggle via Fn+F1 works properly. Change-Id: Ic7bdb3154a87c4202b5ee1fd333281ef78db1104 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/55657 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/ec/purism/librem/acpi/ec.asl | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/ec/purism/librem/acpi/ec.asl b/src/ec/purism/librem/acpi/ec.asl index abdd8be919..828b44d255 100644 --- a/src/ec/purism/librem/acpi/ec.asl +++ b/src/ec/purism/librem/acpi/ec.asl @@ -176,12 +176,14 @@ Device (EC) Notify (\_SB.SLPB, 0x80) } - /* KEY_F13 (Touchpad Enable/Disable) */ - Method (_Q34) + /* KEY_F13 (Touchpad Enable/Disable) /* + /* Disabled since enabling breaks functionality + with Linux topstar driver */ + /* Method (_Q34) { TPSN (0x87) ^TPAD ^= 1 - } + } */ /* KEY_WLAN */ Method (_Q35)