cpu/x86: Declare SMM_ASEG

This is really an inverse of SMM_TSEG to flag
platforms that should potentially move away
from ASEG implementation.

Change-Id: I3b9007c55c75a59a9e6acc0a0e701300f7d21f87
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34134
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Kyösti Mälkki 2019-07-08 13:48:57 +03:00
parent 328d42f2d8
commit 4d372c7353
9 changed files with 20 additions and 9 deletions

View File

@ -543,10 +543,6 @@ config HAVE_OPTION_TABLE
file containing NVRAM/CMOS bit definitions. file containing NVRAM/CMOS bit definitions.
It defaults to 'n' but can be selected in mainboard/*/Kconfig. It defaults to 'n' but can be selected in mainboard/*/Kconfig.
config HAVE_SMI_HANDLER
bool
default n
config PCI_IO_CFG_EXT config PCI_IO_CFG_EXT
bool bool
default n default n

View File

@ -30,6 +30,7 @@ config CPU_AMD_AGESA
select LAPIC_MONOTONIC_TIMER select LAPIC_MONOTONIC_TIMER
select SPI_FLASH if HAVE_ACPI_RESUME select SPI_FLASH if HAVE_ACPI_RESUME
select POSTCAR_STAGE select POSTCAR_STAGE
select SMM_ASEG
if CPU_AMD_AGESA if CPU_AMD_AGESA

View File

@ -29,6 +29,7 @@ config CPU_AMD_PI
select LAPIC_MONOTONIC_TIMER select LAPIC_MONOTONIC_TIMER
select SPI_FLASH if HAVE_ACPI_RESUME select SPI_FLASH if HAVE_ACPI_RESUME
select POSTCAR_STAGE if !BINARYPI_LEGACY_WRAPPER select POSTCAR_STAGE if !BINARYPI_LEGACY_WRAPPER
select SMM_ASEG
if CPU_AMD_PI if CPU_AMD_PI

View File

@ -6,3 +6,4 @@ config CPU_INTEL_MODEL_F2X
select ARCH_RAMSTAGE_X86_32 select ARCH_RAMSTAGE_X86_32
select SMP select SMP
select SUPPORT_CPU_UCODE_IN_CBFS select SUPPORT_CPU_UCODE_IN_CBFS
select SMM_ASEG

View File

@ -22,3 +22,4 @@ config CPU_QEMU_X86
select SMP select SMP
select UDELAY_TSC select UDELAY_TSC
select C_ENVIRONMENT_BOOTBLOCK select C_ENVIRONMENT_BOOTBLOCK
select SMM_ASEG

View File

@ -88,6 +88,15 @@ config LOGICAL_CPUS
bool bool
default y default y
config HAVE_SMI_HANDLER
bool
default n
depends on (SMM_ASEG || SMM_TSEG)
config SMM_ASEG
bool
default n
config SMM_TSEG config SMM_TSEG
bool bool
default n default n

View File

@ -32,10 +32,9 @@
// ADDR32() macro // ADDR32() macro
#include <arch/registers.h> #include <arch/registers.h>
#if CONFIG(SMM_TSEG) #if !CONFIG(SMM_ASEG)
#error "Don't use this file with TSEG." #error "Only use this file with ASEG."
#endif /* CONFIG_SMM_ASEG */
#endif /* CONFIG_SMM_TSEG */
#define LAPIC_ID 0xfee00020 #define LAPIC_ID 0xfee00020

View File

@ -24,8 +24,11 @@ ramstage-y += lpc.c
ramstage-y += usb.c ramstage-y += usb.c
ramstage-y += usb2.c ramstage-y += usb2.c
ifeq ($(CONFIG_SMM_ASEG),y)
ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c
ramstage-$(CONFIG_HAVE_SMI_HANDLER) += ../../../cpu/x86/smm/smmrelocate.S ramstage-$(CONFIG_HAVE_SMI_HANDLER) += ../../../cpu/x86/smm/smmrelocate.S
endif
smm-y += smihandler.c smm-y += smihandler.c
romstage-y += early_smbus.c romstage-y += early_smbus.c

View File

@ -29,7 +29,7 @@ ramstage-y += ../common/pciehp.c
ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/hda_verb.c ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/hda_verb.c
ifneq ($(CONFIG_SMM_TSEG),y) ifeq ($(CONFIG_SMM_ASEG),y)
ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c ramstage-$(CONFIG_HAVE_SMI_HANDLER) += smi.c
ramstage-$(CONFIG_HAVE_SMI_HANDLER) += ../../../cpu/x86/smm/smmrelocate.S ramstage-$(CONFIG_HAVE_SMI_HANDLER) += ../../../cpu/x86/smm/smmrelocate.S
endif endif