From 4d7539eefdedc4297e1529ee94df7165e2076fa1 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Sat, 28 Jun 2014 15:33:30 +1000 Subject: [PATCH] cpu/x86/pae/pgtbl.c: Unsigned comparison < 0 always false Comparison of unsigned expression < 0 is always false. Change-Id: Idf4e7846b50f4376a5d33515681efbd773d1caca Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/6146 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/cpu/x86/pae/pgtbl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cpu/x86/pae/pgtbl.c b/src/cpu/x86/pae/pgtbl.c index 935473828c..9be415d8de 100644 --- a/src/cpu/x86/pae/pgtbl.c +++ b/src/cpu/x86/pae/pgtbl.c @@ -61,7 +61,7 @@ void *map_2M_page(unsigned long page) void *result; int i; index = cpu_index(); - if ((index < 0) || (index >= CONFIG_MAX_CPUS)) { + if (index >= CONFIG_MAX_CPUS) { return MAPPING_ERROR; } window = page >> 10;