GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86: use proper types for interrupt callbacks 

The mainboard_interrupt_handlers() argument for the function
pointer was using void * as the type. This does not allow the compiler
to catch type differences for the arguments. Thus, some code has been
committed which violates the new interrupt callbacks not taking any
arguments. Make sure the compiler provides a type checking benefit.

Change-Id: Ie20699a368e70c33a9a9912e0fcd63f1e6bb4f18
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/48970
Reviewed-on: http://review.coreboot.org/4141
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Aaron Durbin 2013-04-23 10:25:34 -05:00 committed by Stefan Reinauer
parent 454744fd86
commit 4d7a4c59de
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/arch/x86/include/arch/interrupt.h
View File

@ -23,9 +23,9 @@
/* setup interrupt handlers for mainboard */ /* setup interrupt handlers for mainboard */
#if CONFIG_PCI_OPTION_ROM_RUN_REALMODE #if CONFIG_PCI_OPTION_ROM_RUN_REALMODE
extern void mainboard_interrupt_handlers(int intXX, void *intXX_func); extern void mainboard_interrupt_handlers(int intXX, int (*intXX_func)(void));
#elif CONFIG_PCI_OPTION_ROM_RUN_YABEL #elif CONFIG_PCI_OPTION_ROM_RUN_YABEL
#include <device/oprom/yabel/biosemu.h> #include <device/oprom/yabel/biosemu.h>
#else #else
static inline void mainboard_interrupt_handlers(int intXX, void *intXX_func) { } static inline void mainboard_interrupt_handlers(int intXX, int (*intXX_func)(void)) { }
#endif #endif

2
src/device/oprom/realmode/x86.c
View File

@ -118,7 +118,7 @@ static int intXX_unknown_handler(void)
} }
/* setup interrupt handlers for mainboard */ /* setup interrupt handlers for mainboard */
void mainboard_interrupt_handlers(int intXX, void *intXX_func) void mainboard_interrupt_handlers(int intXX, int (*intXX_func)(void))
{ {
intXX_handler[intXX] = intXX_func; intXX_handler[intXX] = intXX_func;
} }