src/mainboard: Drop wrong _ADR objects
ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both." Change-Id: I50cafce0aaf465ee95562ccff6c8f63fb22096c0 Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36294 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
parent
5216b72a99
commit
4d99cdeaf9
|
@ -46,7 +46,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, OEM_ID, ACPI_TABLE_CREATOR, 100925440)
|
||||||
External (CBB2)
|
External (CBB2)
|
||||||
|
|
||||||
Name (_HID, EisaId ("PNP0A03"))
|
Name (_HID, EisaId ("PNP0A03"))
|
||||||
Name (_ADR, 0x00000000)
|
|
||||||
Name (_UID, 0x01)
|
Name (_UID, 0x01)
|
||||||
|
|
||||||
Name (HCIN, 0x00) // HC1
|
Name (HCIN, 0x00) // HC1
|
||||||
|
@ -118,7 +117,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, OEM_ID, ACPI_TABLE_CREATOR, 100925440)
|
||||||
Device (PCI1)
|
Device (PCI1)
|
||||||
{
|
{
|
||||||
Name (_HID, "PNP0A03")
|
Name (_HID, "PNP0A03")
|
||||||
Name (_ADR, 0x00000000)
|
|
||||||
Name (_UID, 0x02)
|
Name (_UID, 0x02)
|
||||||
Method (_STA, 0, NotSerialized)
|
Method (_STA, 0, NotSerialized)
|
||||||
{
|
{
|
||||||
|
@ -133,7 +131,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, OEM_ID, ACPI_TABLE_CREATOR, 100925440)
|
||||||
Device (PCI2)
|
Device (PCI2)
|
||||||
{
|
{
|
||||||
Name (_HID, "PNP0A03")
|
Name (_HID, "PNP0A03")
|
||||||
Name (_ADR, 0x00000000)
|
|
||||||
Name (_UID, 0x02)
|
Name (_UID, 0x02)
|
||||||
Method (_STA, 0, NotSerialized)
|
Method (_STA, 0, NotSerialized)
|
||||||
{
|
{
|
||||||
|
|
|
@ -28,7 +28,6 @@ Scope(\_SB)
|
||||||
{
|
{
|
||||||
Device(PCI0) {
|
Device(PCI0) {
|
||||||
Name (_HID, EISAID("PNP0A03"))
|
Name (_HID, EISAID("PNP0A03"))
|
||||||
Name (_ADR, 0x00)
|
|
||||||
Name (_PRT, Package() {
|
Name (_PRT, Package() {
|
||||||
Package() { 0x001dffff, 0, 0, 16 },
|
Package() { 0x001dffff, 0, 0, 16 },
|
||||||
Package() { 0x001dffff, 1, 0, 19 },
|
Package() { 0x001dffff, 1, 0, 19 },
|
||||||
|
|
|
@ -128,7 +128,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, OEM_ID, ACPI_TABLE_CREATOR, 1)
|
||||||
Device (PCI0)
|
Device (PCI0)
|
||||||
{
|
{
|
||||||
Name (_HID, EisaId ("PNP0A03"))
|
Name (_HID, EisaId ("PNP0A03"))
|
||||||
Name (_ADR, 0x00)
|
|
||||||
Name (_UID, 0x00)
|
Name (_UID, 0x00)
|
||||||
Name (_BBN, 0x00)
|
Name (_BBN, 0x00)
|
||||||
|
|
||||||
|
|
|
@ -124,7 +124,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, OEM_ID, ACPI_TABLE_CREATOR, 1)
|
||||||
Device (PCI0)
|
Device (PCI0)
|
||||||
{
|
{
|
||||||
Name (_HID, EisaId ("PNP0A03"))
|
Name (_HID, EisaId ("PNP0A03"))
|
||||||
Name (_ADR, 0x00)
|
|
||||||
Name (_UID, 0x00)
|
Name (_UID, 0x00)
|
||||||
Name (_BBN, 0x00)
|
Name (_BBN, 0x00)
|
||||||
|
|
||||||
|
|
|
@ -34,7 +34,6 @@ DefinitionBlock (
|
||||||
Scope(\_SB) {
|
Scope(\_SB) {
|
||||||
Device(PCI0) {
|
Device(PCI0) {
|
||||||
Name(_HID, EisaId("PNP0A03"))
|
Name(_HID, EisaId("PNP0A03"))
|
||||||
Name(_ADR, 0x00)
|
|
||||||
Name(_UID, 1)
|
Name(_UID, 1)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -49,7 +49,6 @@ DefinitionBlock (
|
||||||
Device(PCI0) {
|
Device(PCI0) {
|
||||||
Name(_HID, EisaId("PNP0A08"))
|
Name(_HID, EisaId("PNP0A08"))
|
||||||
Name(_CID, EisaId("PNP0A03"))
|
Name(_CID, EisaId("PNP0A03"))
|
||||||
Name(_ADR, 0x00)
|
|
||||||
Name(_UID, 1)
|
Name(_UID, 1)
|
||||||
|
|
||||||
// _OSC: based on sample of ACPI3.0b spec
|
// _OSC: based on sample of ACPI3.0b spec
|
||||||
|
|
|
@ -20,7 +20,6 @@ Scope (\_SB.PCI0.I2C2)
|
||||||
/* Maxim Audio Codec */
|
/* Maxim Audio Codec */
|
||||||
Device (MAXM) /* Audio Codec driver I2C */
|
Device (MAXM) /* Audio Codec driver I2C */
|
||||||
{
|
{
|
||||||
Name (_ADR, 0)
|
|
||||||
Name (_HID, AUDIO_CODEC_HID)
|
Name (_HID, AUDIO_CODEC_HID)
|
||||||
Name (_CID, AUDIO_CODEC_CID)
|
Name (_CID, AUDIO_CODEC_CID)
|
||||||
Name (_DDN, AUDIO_CODEC_DDN)
|
Name (_DDN, AUDIO_CODEC_DDN)
|
||||||
|
@ -64,7 +63,6 @@ Scope (\_SB.PCI0.I2C2)
|
||||||
}
|
}
|
||||||
Device (TISW) /* TI Switch driver I2C */
|
Device (TISW) /* TI Switch driver I2C */
|
||||||
{
|
{
|
||||||
Name (_ADR, 0)
|
|
||||||
Name (_HID, TI_SWITCH_HID)
|
Name (_HID, TI_SWITCH_HID)
|
||||||
Name (_CID, TI_SWITCH_CID)
|
Name (_CID, TI_SWITCH_CID)
|
||||||
Name (_DDN, TI_SWITCH_DDN)
|
Name (_DDN, TI_SWITCH_DDN)
|
||||||
|
|
|
@ -20,7 +20,6 @@ Scope (\_SB.PCI0.I2C5)
|
||||||
/* Realtek Audio Codec */
|
/* Realtek Audio Codec */
|
||||||
Device (RTEK) /* Audio Codec driver I2C */
|
Device (RTEK) /* Audio Codec driver I2C */
|
||||||
{
|
{
|
||||||
Name (_ADR, 0)
|
|
||||||
Name (_HID, AUDIO_CODEC_HID)
|
Name (_HID, AUDIO_CODEC_HID)
|
||||||
Name (_CID, AUDIO_CODEC_CID)
|
Name (_CID, AUDIO_CODEC_CID)
|
||||||
Name (_DDN, AUDIO_CODEC_DDN)
|
Name (_DDN, AUDIO_CODEC_DDN)
|
||||||
|
|
|
@ -43,7 +43,6 @@ Scope (\_SB) {
|
||||||
|
|
||||||
Device (TSCR)
|
Device (TSCR)
|
||||||
{
|
{
|
||||||
Name (_ADR, 0x0)
|
|
||||||
Name (_UID, 2)
|
Name (_UID, 2)
|
||||||
|
|
||||||
// Report as a Sleep Button device so Linux will
|
// Report as a Sleep Button device so Linux will
|
||||||
|
|
|
@ -54,7 +54,6 @@ DefinitionBlock(
|
||||||
Device (UNCR)
|
Device (UNCR)
|
||||||
{
|
{
|
||||||
Name (_BBN, 0xFF)
|
Name (_BBN, 0xFF)
|
||||||
Name (_ADR, 0x00)
|
|
||||||
Name (RID, 0x00)
|
Name (RID, 0x00)
|
||||||
Name (_HID, EisaId ("PNP0A03"))
|
Name (_HID, EisaId ("PNP0A03"))
|
||||||
Name (_CRS, ResourceTemplate ()
|
Name (_CRS, ResourceTemplate ()
|
||||||
|
|
|
@ -54,7 +54,6 @@ DefinitionBlock(
|
||||||
Device (UNCR)
|
Device (UNCR)
|
||||||
{
|
{
|
||||||
Name (_BBN, 0xFF)
|
Name (_BBN, 0xFF)
|
||||||
Name (_ADR, 0x00)
|
|
||||||
Name (RID, 0x00)
|
Name (RID, 0x00)
|
||||||
Name (_HID, EisaId ("PNP0A03"))
|
Name (_HID, EisaId ("PNP0A03"))
|
||||||
Name (_CRS, ResourceTemplate ()
|
Name (_CRS, ResourceTemplate ()
|
||||||
|
|
|
@ -36,7 +36,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, OEM_ID, ACPI_TABLE_CREATOR, 1)
|
||||||
Device (PCI0)
|
Device (PCI0)
|
||||||
{
|
{
|
||||||
Name (_HID, EisaId ("PNP0A03"))
|
Name (_HID, EisaId ("PNP0A03"))
|
||||||
Name (_ADR, 0x00)
|
|
||||||
Name (_UID, 0x00)
|
Name (_UID, 0x00)
|
||||||
Name (_BBN, 0x00)
|
Name (_BBN, 0x00)
|
||||||
|
|
||||||
|
|
|
@ -48,7 +48,6 @@ DefinitionBlock(
|
||||||
Device (UNCR)
|
Device (UNCR)
|
||||||
{
|
{
|
||||||
Name (_BBN, 0xFF)
|
Name (_BBN, 0xFF)
|
||||||
Name (_ADR, 0x00)
|
|
||||||
Name (RID, 0x00)
|
Name (RID, 0x00)
|
||||||
Name (_HID, EisaId ("PNP0A03"))
|
Name (_HID, EisaId ("PNP0A03"))
|
||||||
Name (_CRS, ResourceTemplate ()
|
Name (_CRS, ResourceTemplate ()
|
||||||
|
|
Loading…
Reference in New Issue