From 4da8830c3d4f65b2bd53ed1c0f4fd7f623ca8c1e Mon Sep 17 00:00:00 2001 From: Dinesh Gehlot Date: Tue, 17 Jan 2023 05:46:33 +0000 Subject: [PATCH] soc/intel/jasperlake: Use common gpio.h include Replace the intelblocks/gpio.h, soc/gpio.h and soc/gpio_defs.h includes with the common gpio.h which includes soc/gpio.h which includes intelblocks/gpio.h which includes soc/gpio_defs.h. This patch also fixes alphabetic ordering of included headers. BUG=b:261778357 TEST=Able to build and boot. Signed-off-by: Dinesh Gehlot Change-Id: If069e66f2762eb373d35d635c09226ac5be99c7d Reviewed-on: https://review.coreboot.org/c/coreboot/+/72039 Reviewed-by: Elyes Haouas Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/soc/intel/jasperlake/acpi/gpio.asl | 3 +-- src/soc/intel/jasperlake/chip.c | 2 +- src/soc/intel/jasperlake/chip.h | 3 +-- src/soc/intel/jasperlake/gpio.c | 2 +- src/soc/intel/jasperlake/pmutil.c | 4 ++-- 5 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/soc/intel/jasperlake/acpi/gpio.asl b/src/soc/intel/jasperlake/acpi/gpio.asl index 421abc3a21..786a6c69ab 100644 --- a/src/soc/intel/jasperlake/acpi/gpio.asl +++ b/src/soc/intel/jasperlake/acpi/gpio.asl @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include +#include #include -#include #include #include diff --git a/src/soc/intel/jasperlake/chip.c b/src/soc/intel/jasperlake/chip.c index 3464399405..567dccb6c9 100644 --- a/src/soc/intel/jasperlake/chip.c +++ b/src/soc/intel/jasperlake/chip.c @@ -4,9 +4,9 @@ #include #include #include +#include #include #include -#include #include #include #include diff --git a/src/soc/intel/jasperlake/chip.h b/src/soc/intel/jasperlake/chip.h index 896a79a0f9..2839148764 100644 --- a/src/soc/intel/jasperlake/chip.h +++ b/src/soc/intel/jasperlake/chip.h @@ -4,13 +4,12 @@ #define _SOC_CHIP_H_ #include +#include #include -#include #include #include #include #include -#include #include #include #include diff --git a/src/soc/intel/jasperlake/gpio.c b/src/soc/intel/jasperlake/gpio.c index 7ffc2aa8de..42eb183aff 100644 --- a/src/soc/intel/jasperlake/gpio.c +++ b/src/soc/intel/jasperlake/gpio.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include +#include #include #include #include diff --git a/src/soc/intel/jasperlake/pmutil.c b/src/soc/intel/jasperlake/pmutil.c index 23d5fe77ff..b438e9db0e 100644 --- a/src/soc/intel/jasperlake/pmutil.c +++ b/src/soc/intel/jasperlake/pmutil.c @@ -8,17 +8,17 @@ #define __SIMPLE_DEVICE__ #include +#include #include #include #include #include -#include +#include #include #include #include #include #include -#include #include #include #include