From 4e03727e63b1af7f5bdb9df42f40801052c6a11d Mon Sep 17 00:00:00 2001 From: Felix Held Date: Wed, 23 Feb 2022 16:35:58 +0100 Subject: [PATCH] arch/x86/Kconfig: add HPET_MIN_TICKS Some Intel southbridges have HPET_MIN_TICKS in their Kconfig files, but the CONFIG_HPET_MIN_TICKS symbol is used in the common acpi code in acpi/acpi.c, so define this option in arch/x86/Kconfig to have it defined in all cases where the function that ends up using this information gets called. Since we now have the type information for this Kconfig option in a central place, it can be dropped from the Kconfig file of the Intel southbridges that change the default value. Signed-off-by: Felix Held Change-Id: Ibe012069dd4b51c15a8fbc6459186ad2ea405a03 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62298 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/arch/x86/Kconfig | 3 +++ src/southbridge/intel/bd82x6x/Kconfig | 1 - src/southbridge/intel/i82801gx/Kconfig | 1 - src/southbridge/intel/i82801ix/Kconfig | 1 - src/southbridge/intel/i82801jx/Kconfig | 1 - src/southbridge/intel/ibexpeak/Kconfig | 1 - src/southbridge/intel/lynxpoint/Kconfig | 1 - 7 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index d218e9195f..f09840dcd7 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -195,6 +195,9 @@ config HPET_ADDRESS hex default 0xfed00000 +config HPET_MIN_TICKS + hex + config C_ENV_BOOTBLOCK_SIZE hex default 0x40000 if !FIXED_BOOTBLOCK_SIZE diff --git a/src/southbridge/intel/bd82x6x/Kconfig b/src/southbridge/intel/bd82x6x/Kconfig index c9e86625d2..168c18e26c 100644 --- a/src/southbridge/intel/bd82x6x/Kconfig +++ b/src/southbridge/intel/bd82x6x/Kconfig @@ -53,7 +53,6 @@ config SERIRQ_CONTINUOUS_MODE operated in continuous mode. config HPET_MIN_TICKS - hex default 0x80 config HIDE_MEI_ON_ERROR diff --git a/src/southbridge/intel/i82801gx/Kconfig b/src/southbridge/intel/i82801gx/Kconfig index 399d7e0bbb..9e7259f121 100644 --- a/src/southbridge/intel/i82801gx/Kconfig +++ b/src/southbridge/intel/i82801gx/Kconfig @@ -30,7 +30,6 @@ config EHCI_BAR default 0xfef00000 config HPET_MIN_TICKS - hex default 0x80 config INTEL_TOP_SWAP_BOOTBLOCK_SIZE diff --git a/src/southbridge/intel/i82801ix/Kconfig b/src/southbridge/intel/i82801ix/Kconfig index 39f5e83b25..0b4501627c 100644 --- a/src/southbridge/intel/i82801ix/Kconfig +++ b/src/southbridge/intel/i82801ix/Kconfig @@ -29,7 +29,6 @@ config EHCI_BAR default 0xfef00000 config HPET_MIN_TICKS - hex default 0x80 ## Some enterprise variants may require an IFD diff --git a/src/southbridge/intel/i82801jx/Kconfig b/src/southbridge/intel/i82801jx/Kconfig index 197ed523f6..13357c7238 100644 --- a/src/southbridge/intel/i82801jx/Kconfig +++ b/src/southbridge/intel/i82801jx/Kconfig @@ -30,7 +30,6 @@ config EHCI_BAR default 0xfef00000 config HPET_MIN_TICKS - hex default 0x80 ## Some enterprise variants may require an IFD diff --git a/src/southbridge/intel/ibexpeak/Kconfig b/src/southbridge/intel/ibexpeak/Kconfig index 6972da7613..a79b3f73af 100644 --- a/src/southbridge/intel/ibexpeak/Kconfig +++ b/src/southbridge/intel/ibexpeak/Kconfig @@ -49,7 +49,6 @@ config SERIRQ_CONTINUOUS_MODE operated in continuous mode. config HPET_MIN_TICKS - hex default 0x80 config HIDE_MEI_ON_ERROR diff --git a/src/southbridge/intel/lynxpoint/Kconfig b/src/southbridge/intel/lynxpoint/Kconfig index 891b06a4a5..b188251d8b 100644 --- a/src/southbridge/intel/lynxpoint/Kconfig +++ b/src/southbridge/intel/lynxpoint/Kconfig @@ -53,7 +53,6 @@ config SERIRQ_CONTINUOUS_MODE operated in continuous mode. config HPET_MIN_TICKS - hex default 0x80 config FINALIZE_USB_ROUTE_XHCI