GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge/raminit: Add comments 

Add comments found when testing ECC scrubbing code.
This is a cosmetic change.

Change-Id: I7975f6070c2002930eec407a6b101a1295495b25
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40947
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Patrick Rudolph 2020-05-01 18:35:36 +02:00 committed by Angel Pons
parent b5fa9c8200
commit 4e0cd82b5b
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/northbridge/intel/sandybridge/raminit_common.c
View File

@ -319,8 +319,14 @@ void dram_dimm_mapping(ramctr_timing *ctrl)
reg |= (dimmB->width / 8 - 1) << 20; reg |= (dimmB->width / 8 - 1) << 20;
} }
reg |= 1 << 21; /* Rank interleave */ /*
reg |= 1 << 22; /* Enhanced interleave */ * Rank interleave: Bit 16 of the physical address space sets
* the rank to use in a dual single rank DIMM configuration.
* That results in every 64KiB being interleaved between two ranks.
*/
reg |= 1 << 21;
/* Enhanced interleave */
reg |= 1 << 22;
if ((dimmA && (dimmA->ranks > 0)) || (dimmB && (dimmB->ranks > 0))) { if ((dimmA && (dimmA->ranks > 0)) || (dimmB && (dimmB->ranks > 0))) {
ctrl->mad_dimm[channel] = reg; ctrl->mad_dimm[channel] = reg;