From 4f86e1da8184738a29f11fe6713799cc2254305d Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Wed, 20 Sep 2023 16:30:06 -0500 Subject: [PATCH] mb/google/puff: Hide LSPCON device from Windows Puff-based Chromeboxes use a LSPCON for HDMI 2.0 output, but no driver exists or is needed for Windows. Use the devicetree hidden keyword to set the ACPI status to hidden for these devices, to prevent unknown devices from being listed in Windows Device Manager. TEST=build/boot Win11 on google/wyvern, verify no unknown devices in Windows Device Manager for either LSPCON device. Change-Id: Ib646e01a337b8d7baf20a886c49a8cb64d6408f3 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/78040 Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) Reviewed-by: Martin L Roth Reviewed-by: Felix Singer Reviewed-by: Paul Menzel --- src/mainboard/google/puff/variants/ambassador/overridetree.cb | 4 ++-- src/mainboard/google/puff/variants/duffy/overridetree.cb | 4 ++-- src/mainboard/google/puff/variants/faffy/overridetree.cb | 4 ++-- src/mainboard/google/puff/variants/genesis/overridetree.cb | 4 ++-- src/mainboard/google/puff/variants/kaisa/overridetree.cb | 4 ++-- src/mainboard/google/puff/variants/moonbuggy/overridetree.cb | 4 ++-- src/mainboard/google/puff/variants/noibat/overridetree.cb | 4 ++-- src/mainboard/google/puff/variants/puff/overridetree.cb | 4 ++-- src/mainboard/google/puff/variants/wyvern/overridetree.cb | 4 ++-- 9 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/mainboard/google/puff/variants/ambassador/overridetree.cb b/src/mainboard/google/puff/variants/ambassador/overridetree.cb index 5a1002a709..12fcfdbee4 100644 --- a/src/mainboard/google/puff/variants/ambassador/overridetree.cb +++ b/src/mainboard/google/puff/variants/ambassador/overridetree.cb @@ -354,7 +354,7 @@ chip soc/intel/cannonlake register "hid" = ""1AF80175"" register "name" = ""PS17"" register "desc" = ""Parade PS175"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c3 on @@ -363,7 +363,7 @@ chip soc/intel/cannonlake register "hid" = ""10EC2142"" register "name" = ""RTD2"" register "desc" = ""Realtek RTD2142"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c4 on diff --git a/src/mainboard/google/puff/variants/duffy/overridetree.cb b/src/mainboard/google/puff/variants/duffy/overridetree.cb index 27768df5df..38752d2790 100644 --- a/src/mainboard/google/puff/variants/duffy/overridetree.cb +++ b/src/mainboard/google/puff/variants/duffy/overridetree.cb @@ -413,7 +413,7 @@ chip soc/intel/cannonlake register "hid" = ""1AF80175"" register "name" = ""PS17"" register "desc" = ""Parade PS175"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c3 on @@ -422,7 +422,7 @@ chip soc/intel/cannonlake register "hid" = ""10EC2142"" register "name" = ""RTD2"" register "desc" = ""Realtek RTD2142"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c4 on diff --git a/src/mainboard/google/puff/variants/faffy/overridetree.cb b/src/mainboard/google/puff/variants/faffy/overridetree.cb index d024043bce..3bfb9b4610 100644 --- a/src/mainboard/google/puff/variants/faffy/overridetree.cb +++ b/src/mainboard/google/puff/variants/faffy/overridetree.cb @@ -387,7 +387,7 @@ chip soc/intel/cannonlake register "hid" = ""1AF80175"" register "name" = ""PS17"" register "desc" = ""Parade PS175"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c3 on @@ -396,7 +396,7 @@ chip soc/intel/cannonlake register "hid" = ""10EC2142"" register "name" = ""RTD2"" register "desc" = ""Realtek RTD2142"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c4 on diff --git a/src/mainboard/google/puff/variants/genesis/overridetree.cb b/src/mainboard/google/puff/variants/genesis/overridetree.cb index 2ec3aa1129..e2f3fde6f3 100644 --- a/src/mainboard/google/puff/variants/genesis/overridetree.cb +++ b/src/mainboard/google/puff/variants/genesis/overridetree.cb @@ -384,7 +384,7 @@ chip soc/intel/cannonlake register "hid" = ""1AF80175"" register "name" = ""PS17"" register "desc" = ""Parade PS175"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c3 on @@ -393,7 +393,7 @@ chip soc/intel/cannonlake register "hid" = ""10EC2142"" register "name" = ""RTD2"" register "desc" = ""Realtek RTD2142"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c4 on diff --git a/src/mainboard/google/puff/variants/kaisa/overridetree.cb b/src/mainboard/google/puff/variants/kaisa/overridetree.cb index 3e71aa46bf..7c4ca92c41 100644 --- a/src/mainboard/google/puff/variants/kaisa/overridetree.cb +++ b/src/mainboard/google/puff/variants/kaisa/overridetree.cb @@ -413,7 +413,7 @@ chip soc/intel/cannonlake register "hid" = ""1AF80175"" register "name" = ""PS17"" register "desc" = ""Parade PS175"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c3 on @@ -422,7 +422,7 @@ chip soc/intel/cannonlake register "hid" = ""10EC2142"" register "name" = ""RTD2"" register "desc" = ""Realtek RTD2142"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c4 on diff --git a/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb b/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb index aa2377e878..95f6965e40 100644 --- a/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb +++ b/src/mainboard/google/puff/variants/moonbuggy/overridetree.cb @@ -386,7 +386,7 @@ chip soc/intel/cannonlake register "hid" = ""1AF80175"" register "name" = ""PS17"" register "desc" = ""Parade PS175"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c3 on @@ -395,7 +395,7 @@ chip soc/intel/cannonlake register "hid" = ""10EC2142"" register "name" = ""RTD2"" register "desc" = ""Realtek RTD2142"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c4 on diff --git a/src/mainboard/google/puff/variants/noibat/overridetree.cb b/src/mainboard/google/puff/variants/noibat/overridetree.cb index 0986048861..9fb85878bf 100644 --- a/src/mainboard/google/puff/variants/noibat/overridetree.cb +++ b/src/mainboard/google/puff/variants/noibat/overridetree.cb @@ -324,7 +324,7 @@ chip soc/intel/cannonlake register "hid" = ""1AF80175"" register "name" = ""PS17"" register "desc" = ""Parade PS175"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c3 on @@ -333,7 +333,7 @@ chip soc/intel/cannonlake register "hid" = ""10EC2142"" register "name" = ""RTD2"" register "desc" = ""Realtek RTD2142"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c4 on diff --git a/src/mainboard/google/puff/variants/puff/overridetree.cb b/src/mainboard/google/puff/variants/puff/overridetree.cb index 349740cf57..e7f4a5144d 100644 --- a/src/mainboard/google/puff/variants/puff/overridetree.cb +++ b/src/mainboard/google/puff/variants/puff/overridetree.cb @@ -348,7 +348,7 @@ chip soc/intel/cannonlake register "hid" = ""1AF80175"" register "name" = ""PS17"" register "desc" = ""Parade PS175"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c3 on @@ -357,7 +357,7 @@ chip soc/intel/cannonlake register "hid" = ""10EC2142"" register "name" = ""RTD2"" register "desc" = ""Realtek RTD2142"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c4 on diff --git a/src/mainboard/google/puff/variants/wyvern/overridetree.cb b/src/mainboard/google/puff/variants/wyvern/overridetree.cb index 89530f3dd9..8adbb5c5c9 100644 --- a/src/mainboard/google/puff/variants/wyvern/overridetree.cb +++ b/src/mainboard/google/puff/variants/wyvern/overridetree.cb @@ -349,7 +349,7 @@ chip soc/intel/cannonlake register "hid" = ""1AF80175"" register "name" = ""PS17"" register "desc" = ""Parade PS175"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c3 on @@ -358,7 +358,7 @@ chip soc/intel/cannonlake register "hid" = ""10EC2142"" register "name" = ""RTD2"" register "desc" = ""Realtek RTD2142"" - device i2c 4a on end + device i2c 4a hidden end end end device ref i2c4 on