GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lynxpoint/broadwell: Use `azalia_codecs_init()` 

Use the functionally-equivalent common Azalia code to get rid of
redundant code.

Change-Id: Id25d2797a91b05264b1a76fa8faec0533dd5ac78
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59120
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2021-11-10 18:09:04 +01:00 committed by Paul Fagerburg
parent aae6b55b2d
commit 4f8aea0594
4 changed files with 8 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/intel/broadwell/pch/Kconfig
View File

@ -24,6 +24,9 @@ config PCH_SPECIFIC_OPTIONS
select SOUTHBRIDGE_INTEL_COMMON_SPI_ICH9 select SOUTHBRIDGE_INTEL_COMMON_SPI_ICH9
select SPI_FLASH select SPI_FLASH
config AZALIA_MAX_CODECS
default 4
config EHCI_BAR config EHCI_BAR
hex hex
default 0xd8000000 default 0xd8000000

16
src/soc/intel/broadwell/pch/hda.c
View File

@ -11,20 +11,6 @@
#include <soc/rcba.h> #include <soc/rcba.h>
#include <southbridge/intel/lynxpoint/hda_verb.h> #include <southbridge/intel/lynxpoint/hda_verb.h>
static void codecs_init(u8 *base, u32 codec_mask)
{
int i;
/* Can support up to 4 codecs */
for (i = 3; i >= 0; i--) {
if (codec_mask & (1 << i))
azalia_codec_init(base, i, cim_verb_data, cim_verb_data_size);
}
if (pc_beep_verbs_size)
azalia_program_verb_table(base, pc_beep_verbs, pc_beep_verbs_size);
}
static void hda_pch_init(struct device *dev, u8 *base) static void hda_pch_init(struct device *dev, u8 *base)
{ {
u8 reg8; u8 reg8;
@ -94,7 +80,7 @@ static void hda_init(struct device *dev)
if (codec_mask) { if (codec_mask) {
printk(BIOS_DEBUG, "HDA: codec_mask = %02x\n", codec_mask); printk(BIOS_DEBUG, "HDA: codec_mask = %02x\n", codec_mask);
codecs_init(base, codec_mask); azalia_codecs_init(base, codec_mask);
} }
} }

3
src/southbridge/intel/lynxpoint/Kconfig
View File

@ -41,6 +41,9 @@ config INTEL_LYNXPOINT_LP
help help
Set this option to y for LynxPoint LP (Haswell ULT). Set this option to y for LynxPoint LP (Haswell ULT).
config AZALIA_MAX_CODECS
default 4
config EHCI_BAR config EHCI_BAR
hex hex
default 0xe8000000 default 0xe8000000

16
src/southbridge/intel/lynxpoint/azalia.c
View File

@ -11,20 +11,6 @@
#include "pch.h" #include "pch.h"
#include "hda_verb.h" #include "hda_verb.h"
static void codecs_init(u8 *base, u32 codec_mask)
{
int i;
/* Can support up to 4 codecs */
for (i = 3; i >= 0; i--) {
if (codec_mask & (1 << i))
azalia_codec_init(base, i, cim_verb_data, cim_verb_data_size);
}
if (pc_beep_verbs_size)
azalia_program_verb_table(base, pc_beep_verbs, pc_beep_verbs_size);
}
static void azalia_pch_init(struct device *dev, u8 *base) static void azalia_pch_init(struct device *dev, u8 *base)
{ {
u8 reg8; u8 reg8;
@ -115,7 +101,7 @@ static void azalia_init(struct device *dev)
if (codec_mask) { if (codec_mask) {
printk(BIOS_DEBUG, "Azalia: codec_mask = %02x\n", codec_mask); printk(BIOS_DEBUG, "Azalia: codec_mask = %02x\n", codec_mask);
codecs_init(base, codec_mask); azalia_codecs_init(base, codec_mask);
} }
} }