GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/smbus: Drop some never used boilerplate 

It was added with the words "Update the device header files" and we
maintained it for nearly 13 years :)

These functions are part of the SMBus spec but they are rarely used
and keeping them just in case increases the maintenance burden.

Change-Id: I69a1ea155a21463fc09b7b2c5b7302515a0030b2
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/20439
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Nico Huber 2017-06-30 16:59:42 +02:00 committed by Nico Huber
parent 6bfcf666b0
commit 506bc8e2ff
2 changed files with 0 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/device/smbus_ops.c
View File

@ -92,20 +92,6 @@ int smbus_set_link(device_t dev)
} }
int smbus_quick_read(device_t dev)
{
CHECK_PRESENCE(quick_read);
return ops_smbus_bus(get_pbus_smbus(dev))->quick_read(dev);
}
int smbus_quick_write(device_t dev)
{
CHECK_PRESENCE(quick_write);
return ops_smbus_bus(get_pbus_smbus(dev))->quick_write(dev);
}
int smbus_recv_byte(device_t dev) int smbus_recv_byte(device_t dev)
{ {
CHECK_PRESENCE(recv_byte); CHECK_PRESENCE(recv_byte);
@ -134,27 +120,6 @@ int smbus_write_byte(device_t dev, u8 addr, u8 val)
return ops_smbus_bus(get_pbus_smbus(dev))->write_byte(dev, addr, val); return ops_smbus_bus(get_pbus_smbus(dev))->write_byte(dev, addr, val);
} }
int smbus_read_word(device_t dev, u8 addr)
{
CHECK_PRESENCE(read_word);
return ops_smbus_bus(get_pbus_smbus(dev))->read_word(dev, addr);
}
int smbus_write_word(device_t dev, u8 addr, u16 val)
{
CHECK_PRESENCE(write_word);
return ops_smbus_bus(get_pbus_smbus(dev))->write_word(dev, addr, val);
}
int smbus_process_call(device_t dev, u8 cmd, u16 data)
{
CHECK_PRESENCE(process_call);
return ops_smbus_bus(get_pbus_smbus(dev))->process_call(dev, cmd, data);
}
int smbus_block_read(device_t dev, u8 cmd, u8 bytes, u8 *buffer) int smbus_block_read(device_t dev, u8 cmd, u8 bytes, u8 *buffer)
{ {
CHECK_PRESENCE(block_read); CHECK_PRESENCE(block_read);

10
src/include/device/smbus.h
View File

@ -8,15 +8,10 @@
/* Common SMBus bus operations */ /* Common SMBus bus operations */
struct smbus_bus_operations { struct smbus_bus_operations {
int (*quick_read)(device_t dev);
int (*quick_write)(device_t dev);
int (*recv_byte)(device_t dev); int (*recv_byte)(device_t dev);
int (*send_byte)(device_t dev, u8 value); int (*send_byte)(device_t dev, u8 value);
int (*read_byte)(device_t dev, u8 addr); int (*read_byte)(device_t dev, u8 addr);
int (*write_byte)(device_t dev, u8 addr, u8 value); int (*write_byte)(device_t dev, u8 addr, u8 value);
int (*read_word)(device_t dev, u8 addr);
int (*write_word)(device_t dev, u8 addr, u16 value);
int (*process_call)(device_t dev, u8 cmd, u16 data);
int (*block_read)(device_t dev, u8 cmd, u8 bytes, u8 *buffer); int (*block_read)(device_t dev, u8 cmd, u8 bytes, u8 *buffer);
int (*block_write)(device_t dev, u8 cmd, u8 bytes, const u8 *buffer); int (*block_write)(device_t dev, u8 cmd, u8 bytes, const u8 *buffer);
}; };
@ -35,15 +30,10 @@ static inline const struct smbus_bus_operations *ops_smbus_bus(struct bus *bus)
struct bus *get_pbus_smbus(device_t dev); struct bus *get_pbus_smbus(device_t dev);
int smbus_set_link(device_t dev); int smbus_set_link(device_t dev);
int smbus_quick_read(device_t dev);
int smbus_quick_write(device_t dev);
int smbus_recv_byte(device_t dev); int smbus_recv_byte(device_t dev);
int smbus_send_byte(device_t dev, u8 byte); int smbus_send_byte(device_t dev, u8 byte);
int smbus_read_byte(device_t dev, u8 addr); int smbus_read_byte(device_t dev, u8 addr);
int smbus_write_byte(device_t dev, u8 addr, u8 val); int smbus_write_byte(device_t dev, u8 addr, u8 val);
int smbus_read_word(device_t dev, u8 addr);
int smbus_write_word(device_t dev, u8 addr, u16 val);
int smbus_process_call(device_t dev, u8 cmd, u16 data);
int smbus_block_read(device_t dev, u8 cmd, u8 bytes, u8 *buffer); int smbus_block_read(device_t dev, u8 cmd, u8 bytes, u8 *buffer);
int smbus_block_write(device_t dev, u8 cmd, u8 bytes, const u8 *buffer); int smbus_block_write(device_t dev, u8 cmd, u8 bytes, const u8 *buffer);