From 507b0746d62cff575ab438c4e82ac7cfb0e93f26 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Thu, 24 Mar 2022 01:16:34 +0100 Subject: [PATCH] soc/*: Use __fallthrough statement Clang needs an attribute not a comment. Change-Id: I78f87d80bd4f366ed6cfa74619dd107ac61bc935 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/63068 Tested-by: build bot (Jenkins) Reviewed-by: Julius Werner --- src/soc/nvidia/tegra210/bootblock.c | 2 +- src/soc/rockchip/rk3288/display.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/soc/nvidia/tegra210/bootblock.c b/src/soc/nvidia/tegra210/bootblock.c index 1657d7ce44..e8c4324995 100644 --- a/src/soc/nvidia/tegra210/bootblock.c +++ b/src/soc/nvidia/tegra210/bootblock.c @@ -137,7 +137,7 @@ static void mbist_workaround(void) break; case OP_UDELAY: udelay(wa_op->val); - /* fall thru */ + __fallthrough; default: continue; } diff --git a/src/soc/rockchip/rk3288/display.c b/src/soc/rockchip/rk3288/display.c index 19a75de1fd..9d6cca18b5 100644 --- a/src/soc/rockchip/rk3288/display.c +++ b/src/soc/rockchip/rk3288/display.c @@ -63,7 +63,7 @@ void rk_display_init(struct device *dev, u32 lcdbase, unsigned long fb_size) if (conf->vop_mode == VOP_MODE_EDP) return; } - /* fall thru */ + __fallthrough; case VOP_MODE_HDMI: printk(BIOS_DEBUG, "Attempting to setup HDMI display.\n"); rkclk_configure_hdmi(); @@ -78,7 +78,7 @@ void rk_display_init(struct device *dev, u32 lcdbase, unsigned long fb_size) if (conf->vop_mode == VOP_MODE_HDMI) return; } - /* fall thru */ + __fallthrough; default: printk(BIOS_WARNING, "Cannot read any edid info, aborting.\n"); return;