GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/{drallion,sarien}: Configure GPIOs in mainboard chip->init() 

mainboard_silicon_init_params() is supposed to be used for only
overriding any FSP params as per mainboard configuration. GPIOs should
be configured by mainboard as part of its chip init(). This ensures
proper ordering w.r.t. any common operations that the SoC code might
want to perform e.g. snapshot ITSS polarities.

This change moves the configuration of GPIOs from
mainboard_silicon_init_params() to mainboard chip->init().

Change-Id: I5cd89c6e24b6a4b0c20fd476915f3781a0d46e0d
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36269
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Mathew King <mathewk@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Furquan Shaikh 2019-10-23 11:14:23 -07:00 committed by Patrick Georgi
parent fb9f320d81
commit 514ddef4e5
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/google/drallion/ramstage.c
View File

@ -66,7 +66,7 @@ static const struct pad_config gpio_unused[] = {
/* M2_SKT2_CFG1 */ PAD_NC(GPP_H13, NONE), /* M2_SKT2_CFG1 */ PAD_NC(GPP_H13, NONE),
}; };
void mainboard_silicon_init_params(FSP_S_CONFIG *params) static void mainboard_init(void *chip_info)
{ {
const struct pad_config *gpio_table; const struct pad_config *gpio_table;
size_t num_gpios; size_t num_gpios;
@ -85,5 +85,6 @@ static void mainboard_enable(struct device *dev)
} }
struct chip_operations mainboard_ops = { struct chip_operations mainboard_ops = {
.init = mainboard_init,
.enable_dev = mainboard_enable, .enable_dev = mainboard_enable,
}; };

4
src/mainboard/google/sarien/ramstage.c
View File

@ -18,7 +18,6 @@
#include <drivers/vpd/vpd.h> #include <drivers/vpd/vpd.h>
#include <smbios.h> #include <smbios.h>
#include <soc/gpio.h> #include <soc/gpio.h>
#include <soc/ramstage.h>
#include <variant/gpio.h> #include <variant/gpio.h>
#include <vendorcode/google/chromeos/chromeos.h> #include <vendorcode/google/chromeos/chromeos.h>
@ -68,7 +67,7 @@ static const struct pad_config gpio_unused[] = {
/* M2_SKT2_CFG1 */ PAD_NC(GPP_H13, NONE), /* M2_SKT2_CFG1 */ PAD_NC(GPP_H13, NONE),
}; };
void mainboard_silicon_init_params(FSP_S_CONFIG *params) static void mainboard_init(void *chip_info)
{ {
const struct pad_config *gpio_table; const struct pad_config *gpio_table;
size_t num_gpios; size_t num_gpios;
@ -87,5 +86,6 @@ static void mainboard_enable(struct device *dev)
} }
struct chip_operations mainboard_ops = { struct chip_operations mainboard_ops = {
.init = mainboard_init,
.enable_dev = mainboard_enable, .enable_dev = mainboard_enable,
}; };