GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clarify in the printks what function is actually called. This little smart magic 

drove me crazy during debugging. Fix Typos. Add a warning because the
on-chipset devices are hardcoded. For newer machines, a lot more memory space
will have special meanings, and we can't hardcode them all in an ifdef desert.

(trivial)

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3458 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Stefan Reinauer 2008-08-01 12:28:38 +00:00 committed by Stefan Reinauer
parent 1409136281
commit 51754a38f2
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/devices/device.c
View File

@ -272,7 +272,7 @@ void compute_allocate_resource(
min_align = 0; min_align = 0;
base = bridge->base; base = bridge->base;
printk_spew("%s compute_allocate_%s: base: %08Lx size: %08Lx align: %d gran: %d\n", printk_spew("%s compute_allocate_resource %s: base: %08Lx size: %08Lx align: %d gran: %d\n",
dev_path(bus->dev), dev_path(bus->dev),
(bridge->flags & IORESOURCE_IO)? "io": (bridge->flags & IORESOURCE_IO)? "io":
(bridge->flags & IORESOURCE_PREFETCH)? "prefmem" : "mem", (bridge->flags & IORESOURCE_PREFETCH)? "prefmem" : "mem",
@ -312,7 +312,7 @@ void compute_allocate_resource(
align = min_align; align = min_align;
} }
/* Propogate the resource alignment to the bridge register */ /* Propagate the resource alignment to the bridge register */
if (align > bridge->align) { if (align > bridge->align) {
bridge->align = align; bridge->align = align;
} }
@ -325,10 +325,12 @@ void compute_allocate_resource(
if (bridge->limit > resource->limit) { if (bridge->limit > resource->limit) {
bridge->limit = resource->limit; bridge->limit = resource->limit;
} }
#warning This heuristics should be replaced by real devices with fixed resources.
/* Artificially deny limits between DEVICE_MEM_HIGH and 0xffffffff */ /* Artificially deny limits between DEVICE_MEM_HIGH and 0xffffffff */
if ((bridge->limit > DEVICE_MEM_HIGH) && (bridge->limit <= 0xffffffff)) { if ((bridge->limit > DEVICE_MEM_HIGH) && (bridge->limit <= 0xffffffff)) {
bridge->limit = DEVICE_MEM_HIGH; bridge->limit = DEVICE_MEM_HIGH;
} }
if (resource->flags & IORESOURCE_IO) { if (resource->flags & IORESOURCE_IO) {
/* Don't allow potential aliases over the /* Don't allow potential aliases over the
* legacy pci expansion card addresses. * legacy pci expansion card addresses.
@ -373,7 +375,7 @@ void compute_allocate_resource(
*/ */
bridge->size = round(base, bridge->gran) - bridge->base; bridge->size = round(base, bridge->gran) - bridge->base;
printk_spew("%s compute_allocate_%s: base: %08Lx size: %08Lx align: %d gran: %d done\n", printk_spew("%s compute_allocate_resource %s: base: %08Lx size: %08Lx align: %d gran: %d done\n",
dev_path(bus->dev), dev_path(bus->dev),
(bridge->flags & IORESOURCE_IO)? "io": (bridge->flags & IORESOURCE_IO)? "io":
(bridge->flags & IORESOURCE_PREFETCH)? "prefmem" : "mem", (bridge->flags & IORESOURCE_PREFETCH)? "prefmem" : "mem",
@ -633,7 +635,7 @@ void dev_enumerate(void)
* relocated to their final position and stored to the hardware. * relocated to their final position and stored to the hardware.
* *
* I/O resources start at DEVICE_IO_START and grow upward. MEM resources start * I/O resources start at DEVICE_IO_START and grow upward. MEM resources start
* at DEVICE_MEM_START and grow downward. * at DEVICE_MEM_HIGH and grow downward.
* *
* Since the assignment is hierarchical we set the values into the dev_root * Since the assignment is hierarchical we set the values into the dev_root
* struct. * struct.