GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/poppy/variant/nocturne: don't invert GPP_D17 

This change removes an inversion of GPP_D17 that caused the
device to get stuck in a reboot loop because the kernel was crashing
within the first couple seconds of kernel boot.

BUG=b:142515200
BRANCH=none
TEST=Flash and boot nocturne, verify boot is stable and that device
doesn't reboot after jumping into kernel, and that it passes the
'tast -verbose run <ip> hardware.SensorRing' test.

Change-Id: Ia1408ef6ea92f6b31a9f3eee8720954af3a7c382
Signed-off-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35967
Reviewed-by: Yicheng Li <yichengli@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nick Vaccaro 2019-10-11 10:10:12 -07:00 committed by Martin Roth
parent d3856aad79
commit 523ca8d9b0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/poppy/variants/nocturne/gpio.c
View File

@ -196,7 +196,7 @@ static const struct pad_config gpio_table[] = {
/* D16 : ISH_UART0_CTS# ==> RCAM_RST_L */ /* D16 : ISH_UART0_CTS# ==> RCAM_RST_L */
PAD_CFG_GPO(GPP_D16, 0, DEEP), PAD_CFG_GPO(GPP_D16, 0, DEEP),
/* D17 : DMIC_CLK1 ==> EC_PCH_ARCORE_INT_L */ /* D17 : DMIC_CLK1 ==> EC_PCH_ARCORE_INT_L */
PAD_CFG_GPI_APIC_INVERT(GPP_D17, NONE, PLTRST), PAD_CFG_GPI_APIC(GPP_D17, NONE, PLTRST),
/* D18 : DMIC_DATA1 ==> TP131 */ /* D18 : DMIC_DATA1 ==> TP131 */
PAD_CFG_NC(GPP_D18), PAD_CFG_NC(GPP_D18),
/* D19 : DMIC_CLK0 ==> PCH_DMIC_CLK_OUT */ /* D19 : DMIC_CLK0 ==> PCH_DMIC_CLK_OUT */