GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso: Use AMD common SATA driver 

This change enables the use of AMD common block SATA driver for
Picasso. Since the common driver provides ACPI device name and PCI
device for SATA in SSDT, these are removed from picasso chip.c and
sb_pci0_fch.asl.

BUG=b:153858769
TEST=Verified that "STCR" device is correctly reported on trembyle in
SSDT.

Change-Id: Icfdcf9f5e08820b565aa9fcdd0cdc7b5c9eadcd5
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40770
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Furquan Shaikh 2020-04-27 15:45:20 -07:00
parent 088b9e337c
commit 52f8926159
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/common/block/sata/sata.c
View File

@ -26,6 +26,10 @@ static struct device_operations sata_ops = {
static const unsigned short pci_device_ids[] = { static const unsigned short pci_device_ids[] = {
PCI_DEVICE_ID_AMD_CZ_SATA, PCI_DEVICE_ID_AMD_CZ_SATA,
PCI_DEVICE_ID_AMD_CZ_SATA_AHCI, PCI_DEVICE_ID_AMD_CZ_SATA_AHCI,
PCI_DEVICE_ID_AMD_FAM17H_SATA_AHCI_VER0,
PCI_DEVICE_ID_AMD_FAM17H_SATA_AHCI_VER1,
PCI_DEVICE_ID_AMD_FAM17H_SATA_AHCI_RAID_VER0,
PCI_DEVICE_ID_AMD_FAM17H_SATA_AHCI_RAID_VER1,
0 0
}; };

5
src/soc/amd/picasso/acpi/sb_pci0_fch.asl
View File

@ -23,11 +23,6 @@ Method(_OSC,4)
/* Describe the Southbridge devices */ /* Describe the Southbridge devices */
/* 0:11.0 - SATA */
Device(STCR) {
Name(_ADR, 0x00110000)
} /* end STCR */
/* 0:14.0 - SMBUS */ /* 0:14.0 - SMBUS */
Device(SBUS) { Device(SBUS) {
Name(_ADR, 0x00140000) Name(_ADR, 0x00140000)

2
src/soc/amd/picasso/chip.c
View File

@ -65,8 +65,6 @@ const char *soc_acpi_name(const struct device *dev)
return "AZHD"; return "AZHD";
case LPC_DEVFN: case LPC_DEVFN:
return "LPCB"; return "LPCB";
case SATA_DEVFN:
return "STCR";
case SMBUS_DEVFN: case SMBUS_DEVFN:
return "SBUS"; return "SBUS";
case XHCI0_DEVFN: case XHCI0_DEVFN: