From 532e043b66a6f05ba2d8a73b431913295ed89f11 Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Mon, 21 Feb 2022 18:13:58 +0100 Subject: [PATCH] treewide: Write minor version at acpi_create_fadt() function When "fadt->FADT_MinorVersion" is not explicitly set to the right value, gcc sets it up to "0". So set it correctly for treewide. Signed-off-by: Elyes Haouas Change-Id: Ic9a8e097f78622cd78ba432e3b1141b142485b9a Reviewed-on: https://review.coreboot.org/c/coreboot/+/62221 Tested-by: build bot (Jenkins) Reviewed-by: Jason Glenesk Reviewed-by: Lance Zhao --- src/acpi/acpi.c | 1 + src/soc/amd/picasso/acpi.c | 1 - src/soc/amd/stoneyridge/acpi.c | 1 - src/southbridge/amd/agesa/hudson/fadt.c | 1 - src/southbridge/amd/cimx/sb800/fadt.c | 1 - src/southbridge/amd/pi/hudson/fadt.c | 1 - 6 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index e3f77e0f6a..456fd332dc 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1507,6 +1507,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) memcpy(header->asl_compiler_id, ASLC, 4); header->asl_compiler_revision = asl_revision; + fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->firmware_ctrl = (unsigned long) facs; fadt->x_firmware_ctl_l = (unsigned long)facs; fadt->x_firmware_ctl_h = 0; diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index 2f55aeca44..cd8a0a0968 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -106,7 +106,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) fadt->flags |= cfg->fadt_flags; /* additional board-specific flags */ fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0; diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index ec22704838..4c3b6254fd 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -98,7 +98,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_REMOTE_POWER_ON; fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0; diff --git a/src/southbridge/amd/agesa/hudson/fadt.c b/src/southbridge/amd/agesa/hudson/fadt.c index fb887980da..3aac4506fb 100644 --- a/src/southbridge/amd/agesa/hudson/fadt.c +++ b/src/southbridge/amd/agesa/hudson/fadt.c @@ -63,7 +63,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_REMOTE_POWER_ON; fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO; fadt->x_pm1a_evt_blk.bit_width = 32; diff --git a/src/southbridge/amd/cimx/sb800/fadt.c b/src/southbridge/amd/cimx/sb800/fadt.c index 101c2bf317..9c280a1670 100644 --- a/src/southbridge/amd/cimx/sb800/fadt.c +++ b/src/southbridge/amd/cimx/sb800/fadt.c @@ -87,7 +87,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_REMOTE_POWER_ON; fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO; fadt->x_pm1a_evt_blk.bit_width = 32; diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c index a30202a74f..975b0faa8b 100644 --- a/src/southbridge/amd/pi/hudson/fadt.c +++ b/src/southbridge/amd/pi/hudson/fadt.c @@ -63,7 +63,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt) ACPI_FADT_REMOTE_POWER_ON; fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->FADT_MinorVersion = get_acpi_fadt_minor_version(); fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0;