GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/lenovo/x1_carbon_gen1: add support for hynix memory 

All different memory configuration should be supported by now.
Thanks to Igor Lee.

Change-Id: Ib93c0e3cbdc29cbf6cff26292df4fbbb8208082f
Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
Tested-by: Igor Lee <getrun@gmail.com>
Reviewed-on: https://review.coreboot.org/27781
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Alexander Couzens 2018-08-01 18:59:50 +02:00
parent 5d6593a43c
commit 532e8a9bf5
3 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/mainboard/lenovo/x1_carbon_gen1/romstage.c
View File

@ -95,7 +95,13 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only)
/* 4gb model = 0, 8gb model = 1 */
/* int extended_memory_version = get_gpio(44); */
/* TODO: how do they differ? Guess only one slot is connected */
/*
* So far there is no need to parse gpio 44, as the 4GiB use
* the hynix or elpida memory and 8 GiB versions use samsung.
* All version use both channels.
* But we might miss some versions.
*/
/*
* GPIO45 GPIO25
@ -105,10 +111,8 @@ void mainboard_get_spd(spd_raw_data *spd, bool id_only)
* 1 1 reserved
*/
/* We only support elpida and samsung.
Because the spd data is missing. */
if (spd_index != 0 && spd_index != 2)
die("Unsupported Memory. Please add your SPD dump to coreboot.");
if (spd_index == 3)
die("Unsupported Memory. (detected 'reserved' memory configuration).");
memory = get_spd_data(spd_index);
memcpy(&spd[0], memory, 256);

2
src/mainboard/lenovo/x1_carbon_gen1/spd/Makefile.inc
View File

@ -16,7 +16,7 @@
SPD_BIN = $(obj)/spd.bin
SPD_SOURCES = elpida.hex # 0b0000 Single Channel 2GB
SPD_SOURCES += samsung.hex # 0b0001 placeholder
SPD_SOURCES += hynix.hex # 0b0001 2GiB
SPD_SOURCES += samsung.hex # 0b0010 4GiB
SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f))

16
src/mainboard/lenovo/x1_carbon_gen1/spd/hynix.hex Normal file
View File

@ -0,0 +1,16 @@
92 11 0b 03 04 00 00 02 03 52 01 08 0c 00 20 00
6c 78 6c 3c 6c 11 20 81 28 08 3c 3c 01 68 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 65 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 ae ea
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00