soc/intel: remove duplicate weak versions of mainboard_get_dram_part_num()
Consolidate all weak declarations of mainboard_get_dram_part_num() to instead use the common definition in lib/spd_bin.c. BUG=b:168724473 TEST="emerge-volteer coreboot && emerge-nocturne coreboot && emerge-dedede coreboot" and verify build succeeds without error. Change-Id: I322899c080ab7ebcf1cdcad3ce3dfa1d022864d1 Signed-off-by: Nick Vaccaro <nvaccaro@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/45890 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
parent
edecf46187
commit
53b99a84a5
|
@ -2,6 +2,7 @@
|
||||||
|
|
||||||
#include <cbfs.h>
|
#include <cbfs.h>
|
||||||
#include <console/console.h>
|
#include <console/console.h>
|
||||||
|
#include <memory_info.h>
|
||||||
#include <spd_bin.h>
|
#include <spd_bin.h>
|
||||||
#include <string.h>
|
#include <string.h>
|
||||||
#include <device/dram/ddr3.h>
|
#include <device/dram/ddr3.h>
|
||||||
|
@ -17,6 +18,12 @@ void dump_spd_info(struct spd_block *blk)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const char * __weak mainboard_get_dram_part_num(void)
|
||||||
|
{
|
||||||
|
/* Default weak implementation, no need to override part number. */
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
|
||||||
static bool use_ddr4_params(int dram_type)
|
static bool use_ddr4_params(int dram_type)
|
||||||
{
|
{
|
||||||
switch (dram_type) {
|
switch (dram_type) {
|
||||||
|
|
|
@ -21,12 +21,6 @@
|
||||||
0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
|
0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
|
||||||
}
|
}
|
||||||
|
|
||||||
const char * __weak mainboard_get_dram_part_num(void)
|
|
||||||
{
|
|
||||||
/* Default weak implementation, no need to override part number. */
|
|
||||||
return NULL;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Save the DIMM information for SMBIOS table 17 */
|
/* Save the DIMM information for SMBIOS table 17 */
|
||||||
static void save_dimm_info(void)
|
static void save_dimm_info(void)
|
||||||
{
|
{
|
||||||
|
|
|
@ -23,12 +23,6 @@
|
||||||
0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
|
0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
|
||||||
}
|
}
|
||||||
|
|
||||||
const char * __weak mainboard_get_dram_part_num(void)
|
|
||||||
{
|
|
||||||
/* Default weak implementation, no need to override part number. */
|
|
||||||
return NULL;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Save the DIMM information for SMBIOS table 17 */
|
/* Save the DIMM information for SMBIOS table 17 */
|
||||||
static void save_dimm_info(void)
|
static void save_dimm_info(void)
|
||||||
{
|
{
|
||||||
|
|
|
@ -21,12 +21,6 @@
|
||||||
0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
|
0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
|
||||||
}
|
}
|
||||||
|
|
||||||
const char * __weak mainboard_get_dram_part_num(void)
|
|
||||||
{
|
|
||||||
/* Default implementation, no need to override part number. */
|
|
||||||
return NULL;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Save the DIMM information for SMBIOS table 17 */
|
/* Save the DIMM information for SMBIOS table 17 */
|
||||||
static void save_dimm_info(void)
|
static void save_dimm_info(void)
|
||||||
{
|
{
|
||||||
|
|
|
@ -21,12 +21,6 @@
|
||||||
0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
|
0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
|
||||||
}
|
}
|
||||||
|
|
||||||
const char * __weak mainboard_get_dram_part_num(void)
|
|
||||||
{
|
|
||||||
/* Default weak implementation, no need to override part number. */
|
|
||||||
return NULL;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Save the DIMM information for SMBIOS table 17 */
|
/* Save the DIMM information for SMBIOS table 17 */
|
||||||
static void save_dimm_info(void)
|
static void save_dimm_info(void)
|
||||||
{
|
{
|
||||||
|
|
|
@ -21,12 +21,6 @@
|
||||||
0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
|
0x8d, 0x09, 0x11, 0xcf, 0x8b, 0x9f, 0x03, 0x23 \
|
||||||
}
|
}
|
||||||
|
|
||||||
const char * __weak mainboard_get_dram_part_num(void)
|
|
||||||
{
|
|
||||||
/* Default weak implementation, no need to override part number. */
|
|
||||||
return NULL;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Save the DIMM information for SMBIOS table 17 */
|
/* Save the DIMM information for SMBIOS table 17 */
|
||||||
static void save_dimm_info(void)
|
static void save_dimm_info(void)
|
||||||
{
|
{
|
||||||
|
|
Loading…
Reference in New Issue