From 53c22873b049771862e0f9b4cfb3509c07a7d04b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Tue, 26 May 2020 07:32:38 +0300 Subject: [PATCH] drivers/intel/pmx_mux: Remove redundant declaration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: Ie64b267ac01afa9774105e1ab8a7c18021726ff3 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/41871 Reviewed-by: Paul Menzel Reviewed-by: Tim Wawrzynczak Reviewed-by: Duncan Laurie Tested-by: build bot (Jenkins) --- src/drivers/intel/pmc_mux/chip.h | 2 -- src/soc/intel/tigerlake/pmc.c | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/drivers/intel/pmc_mux/chip.h b/src/drivers/intel/pmc_mux/chip.h index f73a07047f..dcca2a3ecc 100644 --- a/src/drivers/intel/pmc_mux/chip.h +++ b/src/drivers/intel/pmc_mux/chip.h @@ -3,8 +3,6 @@ #ifndef __DRIVERS_INTEL_PMC_MUX_H__ #define __DRIVERS_INTEL_PMC_MUX_H__ -extern struct chip_operations drivers_intel_pmc_mux_ops; - struct drivers_intel_pmc_mux_config { }; diff --git a/src/soc/intel/tigerlake/pmc.c b/src/soc/intel/tigerlake/pmc.c index 8fcbe50504..f2f8a06260 100644 --- a/src/soc/intel/tigerlake/pmc.c +++ b/src/soc/intel/tigerlake/pmc.c @@ -126,6 +126,9 @@ static void soc_pmc_fill_ssdt(const struct device *dev) dev_path(dev)); } +/* FIXME: Rewrite loop below without this. */ +extern struct chip_operations drivers_intel_pmc_mux_ops; + /* By default, TGL uses the PMC MUX for all ports, so port_number is unused */ const struct device *soc_get_pmc_mux_device(int port_number) {