GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/cezanne,picasso/reset: use byte I/O read for NCP_ERR 

NCP_ERR is a 1 byte register in I/O-space, so use inb and not inw. The
variable the result gets assigned to is also a uint8_t.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I9fd8c139004111d6227c0316ba2a8b0281541654
Reviewed-on: https://review.coreboot.org/c/coreboot/+/54736
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Felix Held 2021-05-21 02:11:38 +02:00 committed by Patrick Georgi
parent b2b5781bb4
commit 53c83897c4
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/cezanne/reset.c
View File

@ -10,7 +10,7 @@
/* TODO: is NCP_ERR still valid? It appears reserved and always 0xff. b/184281092 */ /* TODO: is NCP_ERR still valid? It appears reserved and always 0xff. b/184281092 */
void set_warm_reset_flag(void) void set_warm_reset_flag(void)
{ {
uint8_t ncp = inw(NCP_ERR); uint8_t ncp = inb(NCP_ERR);
outb(NCP_ERR, ncp | NCP_WARM_BOOT); outb(NCP_ERR, ncp | NCP_WARM_BOOT);
} }

2
src/soc/amd/picasso/reset.c
View File

@ -9,7 +9,7 @@
void set_warm_reset_flag(void) void set_warm_reset_flag(void)
{ {
uint8_t ncp = inw(NCP_ERR); uint8_t ncp = inb(NCP_ERR);
outb(NCP_ERR, ncp | NCP_WARM_BOOT); outb(NCP_ERR, ncp | NCP_WARM_BOOT);
} }