GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vc/amd/agesa/f14/Proc/Mem: Fix uninitialized variable 

Uninitialized variable will contain an arbitrary value left from
earlier computations. This issue has already been addressed
in the f15tn and f16kb versions of this same file, so am
backporting the fix.

Change-Id: Id876107265689e08ad6760e514a4911f32b53da7
Signed-off-by: Joe Moore <awokd@danwin1210.me>
Found-by: Coverity CID 1241856
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38048
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Frans Hendriks <fhendriks@eltan.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Joe Moore 2020-01-01 09:59:09 -07:00 committed by Patrick Georgi
parent b753006f38
commit 53e282acc0
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/vendorcode/amd/agesa/f14/Proc/Mem/Feat/S3/mfs3.c
View File

@ -249,6 +249,7 @@ MemFS3GetDeviceList (
// Base on the size of the device list, apply for a buffer for it. // Base on the size of the device list, apply for a buffer for it.
AllocHeapParams.RequestedBufferSize = BufferSize + sizeof (DEVICE_BLOCK_HEADER); AllocHeapParams.RequestedBufferSize = BufferSize + sizeof (DEVICE_BLOCK_HEADER);
AllocHeapParams.BufferHandle = AMD_S3_NB_INFO_BUFFER_HANDLE; AllocHeapParams.BufferHandle = AMD_S3_NB_INFO_BUFFER_HANDLE;
AllocHeapParams.Persist = HEAP_S3_RESUME;
AGESA_TESTPOINT (TpIfBeforeAllocateMemoryS3SaveBuffer, StdHeader); AGESA_TESTPOINT (TpIfBeforeAllocateMemoryS3SaveBuffer, StdHeader);
if (HeapAllocateBuffer (&AllocHeapParams, StdHeader) != AGESA_SUCCESS) { if (HeapAllocateBuffer (&AllocHeapParams, StdHeader) != AGESA_SUCCESS) {
return AGESA_FATAL; return AGESA_FATAL;