From 5403a8e86141e6392705d6a7f5efdee4b8fe08f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Niew=C3=B6hner?= Date: Sun, 8 Sep 2019 18:03:53 +0200 Subject: [PATCH] superio/common: fix regression in ssdt MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ITR2 is specified twice here, which leads to the following error message in Linux: [ 0.263591] ACPI BIOS Error (bug): Failure creating named object [\_SB.PCI0.LPCB.SIO0.ITR2], AE_ALREADY_EXISTS (20190509/dsfield-633) Add comments and fix duplicated field. As there are no users of this code yet, just rename the fields. Tested on Supermicro X11SSH-TF. Change-Id: I4f3307d0992fcf5ad192f412c2bd15d02572a6b0 Signed-off-by: Michael Niewöhner Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/35294 Reviewed-by: Felix Held Tested-by: build bot (Jenkins) --- src/superio/common/generic.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/superio/common/generic.c b/src/superio/common/generic.c index bffa9f3403..96307a3988 100644 --- a/src/superio/common/generic.c +++ b/src/superio/common/generic.c @@ -113,13 +113,17 @@ static void generic_ssdt(struct device *dev) FIELDLIST_NAMESTR("IOH3", 8), FIELDLIST_NAMESTR("IOL3", 8), FIELDLIST_OFFSET(0x70), - FIELDLIST_NAMESTR("INTR", 4), + /* Interrupt level 0 (IRQ number) */ + FIELDLIST_NAMESTR("ITL0", 4), FIELDLIST_OFFSET(0x71), - FIELDLIST_NAMESTR("INTT", 2), + /* Interrupt type 0 */ + FIELDLIST_NAMESTR("ITT0", 2), FIELDLIST_OFFSET(0x72), - FIELDLIST_NAMESTR("ITR2", 4), + /* Interrupt level 1 (IRQ number) */ + FIELDLIST_NAMESTR("ITL1", 4), FIELDLIST_OFFSET(0x73), - FIELDLIST_NAMESTR("ITR2", 2), + /* Interrupt type 1 */ + FIELDLIST_NAMESTR("ITT1", 2), FIELDLIST_OFFSET(0x74), FIELDLIST_NAMESTR("DMCH", 8), FIELDLIST_OFFSET(0xE0),