GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ACPI S3: Drop ACPI_HUGE_LOWMEM_BACKUP 

ACPI S3 resume path can only modify low memory where
the non-relocatable ramstage resides, there is no need
to maintain a bigger backup copy.

Change-Id: Ifae41b51b359010ec02269c674936a87bd15623b
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/15476
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Kyösti Mälkki 2016-06-28 07:50:48 +03:00
parent a963acdcc7
commit 546a2e8468
3 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Kconfig
View File

@ -485,12 +485,6 @@ config HAVE_ACPI_RESUME
bool bool
default n default n
config ACPI_HUGE_LOWMEM_BACKUP
bool
default n
help
On S3 resume path, backup low memory from RAMBASE..RAMTOP in CBMEM.
config RESUME_PATH_SAME_AS_BOOT config RESUME_PATH_SAME_AS_BOOT
bool bool
default y if ARCH_X86 default y if ARCH_X86

5
src/arch/x86/acpi_s3.c
View File

@ -84,11 +84,6 @@ static int backup_create_or_update(struct resume_backup *backup_mem,
{ {
uintptr_t top; uintptr_t top;
if (CONFIG(ACPI_HUGE_LOWMEM_BACKUP)) {
base = CONFIG_RAMBASE;
size = HIGH_MEMORY_SAVE;
}
/* Align backup region to complete pages. */ /* Align backup region to complete pages. */
top = ALIGN_UP(base + size, BACKUP_PAGE_SZ); top = ALIGN_UP(base + size, BACKUP_PAGE_SZ);
base = ALIGN_DOWN(base, BACKUP_PAGE_SZ); base = ALIGN_DOWN(base, BACKUP_PAGE_SZ);

2
src/arch/x86/include/arch/acpi.h
View File

@ -26,8 +26,6 @@
#ifndef __ASM_ACPI_H #ifndef __ASM_ACPI_H
#define __ASM_ACPI_H #define __ASM_ACPI_H
#define HIGH_MEMORY_SAVE (CONFIG_RAMTOP - CONFIG_RAMBASE)
/* /*
* The type and enable fields are common in ACPI, but the * The type and enable fields are common in ACPI, but the
* values themselves are hardware implementation defined. * values themselves are hardware implementation defined.