From 54c3662a571a6c95bffbaf117a5c5c9255b18917 Mon Sep 17 00:00:00 2001 From: Tim Wawrzynczak Date: Tue, 4 May 2021 10:08:10 -0600 Subject: [PATCH] util/sconfig: Fix null pointer dereferences Should use `name` instead of `field->name`, because `field is supposed to be NULL at this point. TEST=add new field from bits 29-64 to volteer, ensure sconfig prints an error instead of segfaulting. Change-Id: I933330494e0b10e8494a92e93d6beb58fbec0bc1 Found-by: Coverity CID 1452916 Signed-off-by: Tim Wawrzynczak Reviewed-on: https://review.coreboot.org/c/coreboot/+/52888 Reviewed-by: Duncan Laurie Reviewed-by: Furquan Shaikh Tested-by: build bot (Jenkins) --- util/sconfig/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/sconfig/main.c b/util/sconfig/main.c index 111bb502d7..e2a05862bf 100644 --- a/util/sconfig/main.c +++ b/util/sconfig/main.c @@ -450,7 +450,7 @@ struct fw_config_field *new_fw_config_field(const char *name, struct fw_config_f tmp = bits; while (tmp) { if (tmp->start_bit > tmp->end_bit || tmp->end_bit > 63) { - printf("ERROR: fw_config field %s has invalid range %u-%u\n", field->name, + printf("ERROR: fw_config field %s has invalid range %u-%u\n", name, tmp->start_bit, tmp->end_bit); exit(1); }