GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common: Add function to set BILD bit in RTC 

Add a function to set the Bios Interface Lock Down bit (bit 31)
in RTC Configuration register (0x3400). This bit when set prevents
the top swap enable bit (bit 0) in the RTC BUC register (0x3414)
from being changed.

Change-Id: Iacaeeb0d6cabcf0c2c46a58948457ab832351476
Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com>
Reviewed-on: https://review.coreboot.org/28057
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Rizwan Qureshi 2018-08-09 18:10:24 +05:30 committed by Patrick Georgi
parent adfaea5400
commit 55597ff279
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/intel/common/block/include/intelblocks/rtc.h
View File

@ -45,4 +45,6 @@ void configure_rtc_buc_top_swap(enum ts_config ts_state);
*/
enum ts_config get_rtc_buc_top_swap_status(void);
/* Set RTC Configuration BILD bit. */
void rtc_conf_set_bios_interface_lockdown(void);
#endif /* SOC_INTEL_COMMON_BLOCK_RTC_H */

10
src/soc/intel/common/block/rtc/rtc.c
View File

@ -24,10 +24,10 @@
#define PCR_RTC_CONF_UCMOS_EN (1 << 2)
#define PCR_RTC_CONF_LCMOS_LOCK (1 << 3)
#define PCR_RTC_CONF_UCMOS_LOCK (1 << 4)
#define PCR_RTC_CONF_RESERVED (1 << 31)
#define PCR_RTC_CONF_BILD (1 << 31)
/* RTC backed up control register */
#define PCR_RTC_BUC 0x3414
#define PCR_RTC_BUC_TOP_SWAP (1 << 0)
#define PCR_RTC_BUC_TOP_SWAP (1 << 0)
void enable_rtc_upper_bank(void)
{
@ -48,6 +48,12 @@ void rtc_init(void)
cmos_init(soc_get_rtc_failed());
}
void rtc_conf_set_bios_interface_lockdown(void)
{
pcr_rmw32(PID_RTC, PCR_RTC_CONF, ~PCR_RTC_CONF_BILD,
PCR_RTC_CONF_BILD);
}
#if IS_ENABLED(CONFIG_INTEL_HAS_TOP_SWAP)
void configure_rtc_buc_top_swap(enum ts_config ts_state)
{