GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

spi/winbond: Simplify status reg union types 

Having speparate types for the status register with three and four block
protection bits respectively doesn't really make sense, it's the same
size either way just a different representation, so one union type will
do.

This allows us to de-duplicate the status register read in
winbond_get_write_protection as well as removing another layer of union
in 'struct status_regs'.

Change-Id: Ie99b98fb6762c8d84d685b110cfc2fd5458b702e
Signed-off-by: Daniel Gröber <dxld@darkboxed.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42111
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Daniel Gröber 2020-06-04 16:25:13 +02:00 committed by Patrick Georgi
parent a890138968
commit 5569ee9d13
1 changed files with 33 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

75
src/drivers/spi/winbond.c
View File

@ -10,7 +10,7 @@
#include "spi_flash_internal.h" #include "spi_flash_internal.h"
#include "spi_winbond.h" #include "spi_winbond.h"
union status_reg1_bp3 { union status_reg1 {
uint8_t u; uint8_t u;
struct { struct {
uint8_t busy : 1; uint8_t busy : 1;
@ -19,18 +19,14 @@ union status_reg1_bp3 {
uint8_t tb : 1; uint8_t tb : 1;
uint8_t sec : 1; uint8_t sec : 1;
uint8_t srp0 : 1; uint8_t srp0 : 1;
}; } bp3;
};
union status_reg1_bp4 {
uint8_t u;
struct { struct {
uint8_t busy : 1; uint8_t busy : 1;
uint8_t wel : 1; uint8_t wel : 1;
uint8_t bp : 4; uint8_t bp : 4;
uint8_t tb : 1; uint8_t tb : 1;
uint8_t srp0 : 1; uint8_t srp0 : 1;
}; } bp4;
}; };
union status_reg2 { union status_reg2 {
@ -50,15 +46,9 @@ struct status_regs {
struct { struct {
#if defined(__BIG_ENDIAN) #if defined(__BIG_ENDIAN)
union status_reg2 reg2; union status_reg2 reg2;
union { union status_reg1 reg1;
union status_reg1_bp3 reg1_bp3;
union status_reg1_bp4 reg1_bp4;
};
#else #else
union { union status_reg1 reg1;
union status_reg1_bp3 reg1_bp3;
union status_reg1_bp4 reg1_bp4;
};
union status_reg2 reg2; union status_reg2 reg2;
#endif #endif
}; };
@ -267,33 +257,28 @@ static int winbond_get_write_protection(const struct spi_flash *flash,
const size_t granularity = (1 << params->protection_granularity_shift); const size_t granularity = (1 << params->protection_granularity_shift);
union status_reg1 reg1 = { .u = 0 };
ret = spi_flash_cmd(&flash->spi, flash->status_cmd, &reg1.u,
sizeof(reg1.u));
if (ret)
return ret;
if (params->bp_bits == 3) { if (params->bp_bits == 3) {
union status_reg1_bp3 reg1_bp3 = { .u = 0 }; if (reg1.bp3.sec) {
ret = spi_flash_cmd(&flash->spi, flash->status_cmd, &reg1_bp3.u,
sizeof(reg1_bp3.u));
if (reg1_bp3.sec) {
// FIXME: not supported // FIXME: not supported
return -1; return -1;
} }
bp = reg1_bp3.bp; bp = reg1.bp3.bp;
tb = reg1_bp3.tb; tb = reg1.bp3.tb;
} else if (params->bp_bits == 4) { } else if (params->bp_bits == 4) {
union status_reg1_bp4 reg1_bp4 = { .u = 0 }; bp = reg1.bp4.bp;
tb = reg1.bp4.tb;
ret = spi_flash_cmd(&flash->spi, flash->status_cmd, &reg1_bp4.u,
sizeof(reg1_bp4.u));
bp = reg1_bp4.bp;
tb = reg1_bp4.tb;
} else { } else {
// FIXME: not supported // FIXME: not supported
return -1; return -1;
} }
if (ret)
return ret;
ret = spi_flash_cmd(&flash->spi, CMD_W25_RDSR2, &reg2.u, ret = spi_flash_cmd(&flash->spi, CMD_W25_RDSR2, &reg2.u,
sizeof(reg2.u)); sizeof(reg2.u));
@ -482,13 +467,19 @@ winbond_set_write_protection(const struct spi_flash *flash,
/* Write block protection bits */ /* Write block protection bits */
if (params->bp_bits == 3) { if (params->bp_bits == 3) {
val.reg1_bp3 = (union status_reg1_bp3) { .bp = bp, .tb = tb, val.reg1 = (union status_reg1) {
.sec = 0 }; .bp3 = { .bp = bp, .tb = tb, .sec = 0 }
mask.reg1_bp3 = (union status_reg1_bp3) { .bp = ~0, .tb = 1, };
.sec = 1 }; mask.reg1 = (union status_reg1) {
.bp3 = { .bp = ~0, .tb = 1, .sec = 1 }
};
} else { } else {
val.reg1_bp4 = (union status_reg1_bp4) { .bp = bp, .tb = tb }; val.reg1 = (union status_reg1) {
mask.reg1_bp4 = (union status_reg1_bp4) { .bp = ~0, .tb = 1 }; .bp4 = { .bp = bp, .tb = tb }
};
mask.reg1 = (union status_reg1) {
.bp4 = { .bp = ~0, .tb = 1 }
};
} }
val.reg2 = (union status_reg2) { .cmp = cmp }; val.reg2 = (union status_reg2) { .cmp = cmp };
@ -514,11 +505,11 @@ winbond_set_write_protection(const struct spi_flash *flash,
} }
if (params->bp_bits == 3) { if (params->bp_bits == 3) {
val.reg1_bp3.srp0 = !!(srp & 1); val.reg1.bp3.srp0 = !!(srp & 1);
mask.reg1_bp3.srp0 = 1; mask.reg1.bp3.srp0 = 1;
} else { } else {
val.reg1_bp4.srp0 = !!(srp & 1); val.reg1.bp4.srp0 = !!(srp & 1);
mask.reg1_bp4.srp0 = 1; mask.reg1.bp4.srp0 = 1;
} }
val.reg2.srp1 = !!(srp & 2); val.reg2.srp1 = !!(srp & 2);