GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/{google,intel}/{rex,mtlrvp}: Enable SOC_INTEL_COMMON_BASECODE_RAMTOP 

This patch enables the `SOC_INTEL_COMMON_BASECODE_RAMTOP` config
option for select mainboards, as not all board variants may want to
enable this config due to underlying SoC dependencies.

Mainboards that attempt to enable early caching have exhibited soft
hangs while switching between pre-RAM and post-RAM phases. This patch
allows mainboards to choose to enable this option without enabling
it by default (which could cause boot hangs).

Furthermore, it reorganizes the configuration options under
BOARD_GOOGLE_BASEBOARD_REX in alphabetical order for better readability.

BUG=b:306677879
TEST=Enable SOC_INTEL_COMMON_BASECODE_RAMTOP for google/rex and
intel/mtlrvp.

Change-Id: If380c2ecbee4f6437c3d58bfb55be076a4902997
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79048
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
This commit is contained in:
Subrata Banik 2023-11-16 19:24:52 +00:00 committed by Felix Held
parent 3d9a26e7a9
commit 5578d91257
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/mainboard/google/rex/Kconfig
View File

@ -33,6 +33,7 @@ config BOARD_GOOGLE_REX_COMMON
config BOARD_GOOGLE_BASEBOARD_REX config BOARD_GOOGLE_BASEBOARD_REX
def_bool n def_bool n
select BOARD_GOOGLE_REX_COMMON select BOARD_GOOGLE_REX_COMMON
select CHROMEOS_WIFI_SAR if CHROMEOS
select DRIVERS_INTEL_PMC select DRIVERS_INTEL_PMC
select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_GENERIC_GPIO_KEYS
select DRIVERS_WWAN_FM350GL select DRIVERS_WWAN_FM350GL
@ -40,12 +41,12 @@ config BOARD_GOOGLE_BASEBOARD_REX
select HAVE_SLP_S0_GATE select HAVE_SLP_S0_GATE
select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_CHROMEOS
select MEMORY_SOLDERDOWN select MEMORY_SOLDERDOWN
select SOC_INTEL_COMMON_BASECODE_RAMTOP
select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES
select SOC_INTEL_IOE_DIE_SUPPORT select SOC_INTEL_IOE_DIE_SUPPORT
select SOC_INTEL_METEORLAKE_U_H select SOC_INTEL_METEORLAKE_U_H
select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES
select SYSTEM_TYPE_LAPTOP select SYSTEM_TYPE_LAPTOP
select TPM_GOOGLE_TI50 select TPM_GOOGLE_TI50
select CHROMEOS_WIFI_SAR if CHROMEOS
config BOARD_GOOGLE_MODEL_REX config BOARD_GOOGLE_MODEL_REX
def_bool n def_bool n

1
src/mainboard/intel/mtlrvp/Kconfig
View File

@ -17,6 +17,7 @@ config BOARD_INTEL_MTLRVP_COMMON
select HAVE_ACPI_TABLES select HAVE_ACPI_TABLES
select HAVE_SPD_IN_CBFS select HAVE_SPD_IN_CBFS
select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_CHROMEOS
select SOC_INTEL_COMMON_BASECODE_RAMTOP
select SOC_INTEL_COMMON_BLOCK_VARIANT_POWER_LIMIT select SOC_INTEL_COMMON_BLOCK_VARIANT_POWER_LIMIT
select SOC_INTEL_CSE_LITE_SKU select SOC_INTEL_CSE_LITE_SKU
select SOC_INTEL_METEORLAKE_U_H select SOC_INTEL_METEORLAKE_U_H