GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nocturne: Enable debouncing of SX9310 CLOSE / FAR IRQs 

This is meant to solve an issue where the proximity sensor may fluctuate
between CLOSE / FAR in rapid succession upon the user removing their hand
from the unit, before settling on the correct output.

Using the hardware debouncing filter solves this issue and removes the
spurious fluctuations.

BRANCH=None
BUG=None
TEST=manual on Nocturne, observing events come in

Change-Id: I78cc4852d42fcda6209fedce1ce91236b5814571
Signed-off-by: Enrico Granata <egranata@chromium.org>
Reviewed-on: https://review.coreboot.org/28112
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Enrico Granata 2018-08-15 17:13:47 -07:00 committed by Patrick Georgi
parent bb0cf01911
commit 55a8d8a772
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/poppy/variants/nocturne/devicetree.cb
View File

@ -309,7 +309,7 @@ chip soc/intel/skylake
register "reg_prox_ctrl7" = "0x0d" register "reg_prox_ctrl7" = "0x0d"
register "reg_prox_ctrl8" = "0x8d" register "reg_prox_ctrl8" = "0x8d"
register "reg_prox_ctrl9" = "0x43" register "reg_prox_ctrl9" = "0x43"
register "reg_prox_ctrl10" = "0x11" register "reg_prox_ctrl10" = "0x1f"
register "reg_prox_ctrl11" = "0x00" register "reg_prox_ctrl11" = "0x00"
register "reg_prox_ctrl12" = "0x00" register "reg_prox_ctrl12" = "0x00"
register "reg_prox_ctrl13" = "0x00" register "reg_prox_ctrl13" = "0x00"
@ -350,7 +350,7 @@ chip soc/intel/skylake
register "reg_prox_ctrl7" = "0x0d" register "reg_prox_ctrl7" = "0x0d"
register "reg_prox_ctrl8" = "0x8d" register "reg_prox_ctrl8" = "0x8d"
register "reg_prox_ctrl9" = "0x43" register "reg_prox_ctrl9" = "0x43"
register "reg_prox_ctrl10" = "0x11" register "reg_prox_ctrl10" = "0x1f"
register "reg_prox_ctrl11" = "0x00" register "reg_prox_ctrl11" = "0x00"
register "reg_prox_ctrl12" = "0x00" register "reg_prox_ctrl12" = "0x00"
register "reg_prox_ctrl13" = "0x00" register "reg_prox_ctrl13" = "0x00"