GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

superio/smsc/mec1308: Fix IASL warnings 

The SIO device needs to provide an _ADR object with the IO
address as well as the address in the OperationRegion.

ACPI provides two different Resource Descriptor Macros to describe the
I/O areas required for a device.  The FixedIO macro is only valid for
10-bit IO addresses.  Use the IO macro instead.

Thank you to recent IASL that allows for addition in the ASL file.  :)

Fixes these warnings:
dsdt.aml   2276: Device (SIO) {
Warning  3141 -           ^ Missing dependency
(Device object requires a _HID or _ADR in same scope)
dsdt.aml   2390:    FixedIO (0xa00, 0x34)
Warning  3060 -                 ^ Maximum 10-bit ISA address (0x3FF)
dsdt.aml   2394:    FixedIO (0xa00, 0x34)
Warning  3060 -                 ^ Maximum 10-bit ISA address (0x3FF)

Lumpy now compiles its ASL tables with no warnings.  Re-enable
Warnings as errors.

Change-Id: Id26e234eadaa3b966e8f769cb9f9fb7ea64fc9e3
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12520
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Martin Roth 2015-11-23 14:34:51 -07:00
parent e597e63e49
commit 56033a9f2d
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/samsung/lumpy/Kconfig
View File

@ -64,8 +64,4 @@ config EARLY_PCI_MMIO_BASE
endif
# TODO: Remove this when platform ASL is fixed
config IASL_WARNINGS_ARE_ERRORS
def_bool n
endif # BOARD_SAMSUNG_LUMPY

5
src/superio/smsc/mec1308/acpi/superio.asl
View File

@ -16,6 +16,7 @@
// Scope is \_SB.PCI0.LPCB
Device (SIO) {
Name (_ADR, 0x2E)
OperationRegion (SIOA, SystemIO, 0x2E, 0x02)
Field (SIOA, ByteAcc, NoLock, Preserve)
{
@ -245,12 +246,12 @@ Device (SIO) {
Name (_CRS, ResourceTemplate()
{
FixedIO (SIO_SMBX_IO0, 0x34)
IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34)
})
Name (_PRS, ResourceTemplate()
{
FixedIO (SIO_SMBX_IO0, 0x34)
IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34)
})
}
#endif