From 569c653a72cce2a29688f86849d48a5f0f935cf1 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Tue, 11 Dec 2012 17:17:38 -0600 Subject: [PATCH] lynx point: add new ME status information According to the 0.8.0 ME BWG this is a new state. It's not very clear what exactly it entails, but the Basking Ridge CRB was tripping it when MRC_DEBUG was enabled (presumably because of a DID timeout). Instead of 0x17 one can now see the proper message for this state. Change-Id: I5bda1de7d3d957d38a4760a02dcd170ec48782e9 Signed-off-by: Aaron Durbin Reviewed-on: http://review.coreboot.org/2640 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich --- src/southbridge/intel/lynxpoint/me.h | 1 + src/southbridge/intel/lynxpoint/me_status.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/southbridge/intel/lynxpoint/me.h b/src/southbridge/intel/lynxpoint/me.h index 57c4f2409b..a57f779ea5 100644 --- a/src/southbridge/intel/lynxpoint/me.h +++ b/src/southbridge/intel/lynxpoint/me.h @@ -136,6 +136,7 @@ struct me_did { #define ME_HFS2_STATE_BUP_M0 0x12 #define ME_HFS2_STATE_BUP_FLOW_DET_ERR 0x13 #define ME_HFS2_STATE_BUP_M3_CLK_ERR 0x15 +#define ME_HFS2_STATE_BUP_CPU_RESET_DID_TIMEOUT_MEM_MISSING 0x17 #define ME_HFS2_STATE_BUP_M3_KERN_LOAD 0x18 #define ME_HFS2_STATE_BUP_T32_MISSING 0x1c #define ME_HFS2_STATE_BUP_WAIT_DID 0x1f diff --git a/src/southbridge/intel/lynxpoint/me_status.c b/src/southbridge/intel/lynxpoint/me_status.c index 1feaf7d4f0..d09be7b30c 100644 --- a/src/southbridge/intel/lynxpoint/me_status.c +++ b/src/southbridge/intel/lynxpoint/me_status.c @@ -109,6 +109,7 @@ static const char *me_progress_bup_values[] = { [ME_HFS2_STATE_BUP_M0] = "Bringup in M0", [ME_HFS2_STATE_BUP_FLOW_DET_ERR] = "Flow detection error", [ME_HFS2_STATE_BUP_M3_CLK_ERR] = "M3 clock switching error", + [ME_HFS2_STATE_BUP_CPU_RESET_DID_TIMEOUT_MEM_MISSING] = "Host error - CPU reset timeout, DID timeout, memory missing", [ME_HFS2_STATE_BUP_M3_KERN_LOAD] = "M3 kernel load", [ME_HFS2_STATE_BUP_T32_MISSING] = "T34 missing - cannot program ICC", [ME_HFS2_STATE_BUP_WAIT_DID] = "Waiting for DID BIOS message",