From 56d831392566713ba416b822cf2416a6d78a51ae Mon Sep 17 00:00:00 2001 From: Sen Chu Date: Mon, 16 Jan 2023 22:55:06 +0800 Subject: [PATCH] soc/mediatek/mt8188: Allow SSPM to access PWRAP interface Allow SSPM to access PWRAP interface. BUG=b:254566089 TEST=build pass and boot to OS. Change-Id: I4b134983dcde1cc293f4b798f91b997baf96d299 Signed-off-by: Sen Chu Reviewed-on: https://review.coreboot.org/c/coreboot/+/72043 Tested-by: build bot (Jenkins) Reviewed-by: Yu-Ping Wu Reviewed-by: Rex-BC Chen Reviewed-by: Yidi Lin --- src/soc/mediatek/mt8188/pmif_spmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/soc/mediatek/mt8188/pmif_spmi.c b/src/soc/mediatek/mt8188/pmif_spmi.c index 14c830faa6..2d8611b08f 100644 --- a/src/soc/mediatek/mt8188/pmif_spmi.c +++ b/src/soc/mediatek/mt8188/pmif_spmi.c @@ -71,14 +71,13 @@ void pmif_spmi_config(struct pmif *arb, int mstid) write32(&arb->mtk_pmif->inf_cmd_per_2, 0); write32(&arb->mtk_pmif->inf_cmd_per_3, 0); - /* TODO: figure out correct setting for MT8188 */ cmd_per = PMIF_CMD_PER_3 << 28 | PMIF_CMD_PER_3 << 24 | PMIF_CMD_PER_3 << 20 | PMIF_CMD_PER_3 << 16 | PMIF_CMD_PER_3 << 8 | PMIF_CMD_PER_3 << 4 | PMIF_CMD_PER_1_3 << 0; write32(&arb->mtk_pmif->inf_cmd_per_0, cmd_per); - cmd_per = PMIF_CMD_PER_3 << 4; + cmd_per = PMIF_CMD_PER_3 << 8 | PMIF_CMD_PER_3 << 4; write32(&arb->mtk_pmif->inf_cmd_per_1, cmd_per); }