GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/fsp1_1: Reduce scope of functions 

Reduce scope of get_next_hob and drop unused functions.

Change-Id: I81007295ed2d1592c4d829cbb277c0726d89ea4b
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63203
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
This commit is contained in:
Arthur Heymans 2022-03-30 13:34:38 +02:00 committed by Paul Fagerburg
parent 10e47d80cb
commit 56ed0bee86
2 changed files with 1 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/drivers/intel/fsp1_1/hob.c
View File

@ -24,7 +24,7 @@ void *get_hob_list(void)
} }
/* Returns the next instance of a HOB type from the starting HOB. */ /* Returns the next instance of a HOB type from the starting HOB. */
void *get_next_hob(uint16_t type, const void *hob_start) static void *get_next_hob(uint16_t type, const void *hob_start)
{ {
EFI_PEI_HOB_POINTERS hob; EFI_PEI_HOB_POINTERS hob;
@ -44,12 +44,6 @@ void *get_next_hob(uint16_t type, const void *hob_start)
return NULL; return NULL;
} }
/* Returns the first instance of a HOB type among the whole HOB list. */
void *get_first_hob(uint16_t type)
{
return get_next_hob(type, get_hob_list());
}
/* Returns the next instance of the matched GUID HOB from the starting HOB. */ /* Returns the next instance of the matched GUID HOB from the starting HOB. */
void *get_next_guid_hob(const EFI_GUID *guid, const void *hob_start) void *get_next_guid_hob(const EFI_GUID *guid, const void *hob_start)
{ {
@ -65,14 +59,6 @@ void *get_next_guid_hob(const EFI_GUID *guid, const void *hob_start)
return hob.Raw; return hob.Raw;
} }
/*
* Returns the first instance of the matched GUID HOB among the whole HOB list.
*/
void *get_first_guid_hob(const EFI_GUID *guid)
{
return get_next_guid_hob(guid, get_hob_list());
}
/* /*
* Returns the next instance of the matching resource HOB from the starting HOB. * Returns the next instance of the matching resource HOB from the starting HOB.
*/ */
@ -90,15 +76,6 @@ void *get_next_resource_hob(const EFI_GUID *guid, const void *hob_start)
return hob.Raw; return hob.Raw;
} }
/*
* Returns the first instance of the matching resource HOB among the whole HOB
* list.
*/
void *get_first_resource_hob(const EFI_GUID *guid)
{
return get_next_resource_hob(guid, get_hob_list());
}
static void print_hob_mem_attributes(void *hob_ptr) static void print_hob_mem_attributes(void *hob_ptr)
{ {
EFI_MEMORY_TYPE hob_mem_type; EFI_MEMORY_TYPE hob_mem_type;

6
src/drivers/intel/fsp1_1/include/fsp/util.h
View File

@ -24,10 +24,7 @@ void fsp_early_init(FSP_INFO_HEADER *fsp_info);
void fsp_notify(u32 phase); void fsp_notify(u32 phase);
void print_hob_type_structure(u16 hob_type, void *hob_list_ptr); void print_hob_type_structure(u16 hob_type, void *hob_list_ptr);
void print_fsp_info(FSP_INFO_HEADER *fsp_header); void print_fsp_info(FSP_INFO_HEADER *fsp_header);
void *get_next_type_guid_hob(UINT16 type, const EFI_GUID *guid,
const void *hob_start);
void *get_next_resource_hob(const EFI_GUID *guid, const void *hob_start); void *get_next_resource_hob(const EFI_GUID *guid, const void *hob_start);
void *get_first_resource_hob(const EFI_GUID *guid);
void fsp_display_upd_value(const char *name, uint32_t size, uint64_t old, void fsp_display_upd_value(const char *name, uint32_t size, uint64_t old,
uint64_t new); uint64_t new);
void report_fsp_output(void); void report_fsp_output(void);
@ -80,10 +77,7 @@ extern void *FspHobListPtr;
#endif #endif
void *get_hob_list(void); void *get_hob_list(void);
void *get_next_hob(uint16_t type, const void *hob_start);
void *get_first_hob(uint16_t type);
void *get_next_guid_hob(const EFI_GUID *guid, const void *hob_start); void *get_next_guid_hob(const EFI_GUID *guid, const void *hob_start);
void *get_first_guid_hob(const EFI_GUID *guid);
asmlinkage void chipset_teardown_car_main(void); asmlinkage void chipset_teardown_car_main(void);