cpu/intel/model_206ax: Lock MSR on all cores

Lock MSR MSR_PKG_CST_CONFIG_CONTROL on all cores, not only the one
handling APM_CNT_FINALIZE.

Tested on HP Z220: FWTS no longer reports this as an issue.

Change-Id: I174d6c6c74fbba47992084cc44ebddf84eeeabd1
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39199
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Patrick Rudolph 2020-03-02 14:21:32 +01:00 committed by Patrick Georgi
parent 63266c7e66
commit 573481bf6f
2 changed files with 2 additions and 3 deletions

View File

@ -25,9 +25,6 @@
void intel_model_206ax_finalize_smm(void) void intel_model_206ax_finalize_smm(void)
{ {
/* Lock C-State MSR */
msr_set_bit(MSR_PKG_CST_CONFIG_CONTROL, 15);
/* Lock AES-NI only if supported */ /* Lock AES-NI only if supported */
if (cpuid_ecx(1) & (1 << 25)) if (cpuid_ecx(1) & (1 << 25))
msr_set_bit(MSR_FEATURE_CONFIG, 0); msr_set_bit(MSR_FEATURE_CONFIG, 0);

View File

@ -256,6 +256,8 @@ static void configure_c_states(void)
msr.lo |= (1 << 25); // C3 Auto Demotion Enable msr.lo |= (1 << 25); // C3 Auto Demotion Enable
msr.lo &= ~(1 << 10); // Disable IO MWAIT redirection msr.lo &= ~(1 << 10); // Disable IO MWAIT redirection
msr.lo |= 7; // No package C-state limit msr.lo |= 7; // No package C-state limit
msr.lo |= (1 << 15); // Lock C-State MSR
wrmsr(MSR_PKG_CST_CONFIG_CONTROL, msr); wrmsr(MSR_PKG_CST_CONFIG_CONTROL, msr);
msr = rdmsr(MSR_PMG_IO_CAPTURE_ADDR); msr = rdmsr(MSR_PMG_IO_CAPTURE_ADDR);