GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[FLASHROM] Fix the help, and print a message when nothing happens 

The help implied that writes happen by default, which they don't.  Fix
the text, and say something when we dont specify any commands.

Signed-off-by: Jordan Crouse <jordan.crouse@amd.com>    
Acked-by: Stefan Reinauer <stepan@coresystems.de>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2820 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Jordan Crouse 2007-10-04 06:26:41 +00:00 committed by Stefan Reinauer
parent 209148c535
commit 573ff508ab
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
util/flashrom/flashrom.c
View File

@ -195,8 +195,7 @@ void usage(const char *name)
printf(" [-e exclude_end] [-m vendor:part] [-l file.layout] [-i imagename] [file]\n"); printf(" [-e exclude_end] [-m vendor:part] [-l file.layout] [-i imagename] [file]\n");
printf printf
(" -r | --read: read flash and save into file\n" (" -r | --read: read flash and save into file\n"
" -w | --write: write file into flash (default when\n" " -w | --write: write file into flash\n"
" file is specified)\n"
" -v | --verify: verify flash against file\n" " -v | --verify: verify flash against file\n"
" -E | --erase: erase flash device\n" " -E | --erase: erase flash device\n"
" -V | --verbose: more verbose output\n" " -V | --verbose: more verbose output\n"
@ -366,15 +365,22 @@ int main(int argc, char *argv[])
if ((flash = probe_flash(flashchips)) == NULL) { if ((flash = probe_flash(flashchips)) == NULL) {
printf("No EEPROM/flash device found.\n"); printf("No EEPROM/flash device found.\n");
// FIXME: flash writes stay enabled!
exit(1); exit(1);
} }
printf("Flash part is %s (%d KB)\n", flash->name, flash->total_size); printf("Flash part is %s (%d KB)\n", flash->name, flash->total_size);
if (!(read_it | write_it | verify_it | erase_it)) {
printf("No operations were specified.\n");
// FIXME: flash writes stay enabled!
exit(1);
}
if (!filename && !erase_it) { if (!filename && !erase_it) {
// FIXME: Do we really want this feature implicitly? printf("Error: No filename specified.\n");
printf("OK, only ENABLING flash write, but NOT FLASHING.\n"); // FIXME: flash writes stay enabled!
return 0; exit(1);
} }
size = flash->total_size * 1024; size = flash->total_size * 1024;