GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common: Rename crashlog macros 

Remove MAILBOX word from CPU_CRASHLOG_MAILBOX_WAIT_STALL
and CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT macros, because they
can be used for other interface as well.

BUG=b:262501347
TEST=Able to build google/rex.

Change-Id: I62b04fa4b05c427db494a536ca6504db02dfeb68
Signed-off-by: Pratikkumar Prajapati <pratikkumar.v.prajapati@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77236
Reviewed-by: Subrata Banik <subratabanik@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Pratikkumar Prajapati 2023-08-15 11:45:15 -07:00 committed by Martin L Roth
parent 458e2553f5
commit 5849f5bd32
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/intel/common/block/crashlog/crashlog.c
View File

@ -114,13 +114,13 @@ int cpu_cl_poll_mailbox_ready(u32 cl_mailbox_addr)
do {
cl_mailbox_interface.data = read32((u32 *)cl_mailbox_addr);
udelay(CPU_CRASHLOG_MAILBOX_WAIT_STALL);
udelay(CPU_CRASHLOG_WAIT_STALL);
stall_cnt++;
} while ((cl_mailbox_interface.fields.busy == 1)
&& stall_cnt < CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT);
&& stall_cnt < CPU_CRASHLOG_WAIT_TIMEOUT);
if ((cl_mailbox_interface.fields.busy == 1)
&& (stall_cnt >= CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT)) {
&& (stall_cnt >= CPU_CRASHLOG_WAIT_TIMEOUT)) {
printk(BIOS_ERR, "CPU crashlog mailbox timed out.\n");
return 0;
}

4
src/soc/intel/common/block/include/intelblocks/crashlog.h
View File

@ -17,8 +17,8 @@
/* CPU CrashLog Mailbox commands */
#define CPU_CRASHLOG_CMD_DISABLE 0
#define CPU_CRASHLOG_CMD_CLEAR 2
#define CPU_CRASHLOG_MAILBOX_WAIT_STALL 1
#define CPU_CRASHLOG_MAILBOX_WAIT_TIMEOUT 1000
#define CPU_CRASHLOG_WAIT_STALL 1
#define CPU_CRASHLOG_WAIT_TIMEOUT 1000
#define CPU_CRASHLOG_DISC_TAB_GUID_VALID 0x1600
#define CRASHLOG_SIZE_DEBUG_PURPOSE 0x640