GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/gm45: Reserve MMIO and firmware memory below 1MiB 

It looks like we didn't care to reserve the VGA MMIO (a & b segments)
and the c..f segments, initially. It was probably never needed until
the new resource allocator that will make use of any unclaimed space.

Change-Id: Iebdae64914d9f8301cafc67a5aba933c11294707
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49603
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Nico Huber 2021-01-17 21:50:55 +01:00
parent 5fde1b7669
commit 58ba83fe74
1 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/northbridge/intel/gm45/northbridge.c
View File

@ -14,13 +14,6 @@
#include "chip.h" #include "chip.h"
#include "gm45.h" #include "gm45.h"
/* Reserve segments A and B:
*
* 0xa0000 - 0xbffff: legacy VGA
*/
static const int legacy_hole_base_k = 0xa0000 / 1024;
static const int legacy_hole_size_k = 128;
int decode_pcie_bar(u32 *const base, u32 *const len) int decode_pcie_bar(u32 *const base, u32 *const len)
{ {
*base = 0; *base = 0;
@ -133,10 +126,20 @@ static void mch_domain_read_resources(struct device *dev)
printk(BIOS_INFO, "Available memory below 4GB: %uM\n", tomk >> 10); printk(BIOS_INFO, "Available memory below 4GB: %uM\n", tomk >> 10);
/* Report the memory regions */ /* Report lowest memory region */
ram_resource(dev, 3, 0, legacy_hole_base_k); ram_resource(dev, 3, 0, 0xa0000 / KiB);
ram_resource(dev, 4, legacy_hole_base_k + legacy_hole_size_k,
(tomk - (legacy_hole_base_k + legacy_hole_size_k))); /*
* Reserve everything between A segment and 1MB:
*
* 0xa0000 - 0xbffff: Legacy VGA
* 0xc0000 - 0xfffff: RAM
*/
mmio_resource(dev, 4, 0xa0000 / KiB, (0xc0000 - 0xa0000) / KiB);
reserved_ram_resource(dev, 5, 0xc0000 / KiB, (1*MiB - 0xc0000) / KiB);
/* Report < 4GB memory */
ram_resource(dev, 6, 1*MiB / KiB, tomk - 1*MiB / KiB);
/* /*
* If >= 4GB installed then memory from TOLUD to 4GB * If >= 4GB installed then memory from TOLUD to 4GB
@ -144,7 +147,7 @@ static void mch_domain_read_resources(struct device *dev)
*/ */
touud >>= 10; /* Convert to KB */ touud >>= 10; /* Convert to KB */
if (touud > 4096 * 1024) { if (touud > 4096 * 1024) {
ram_resource(dev, 5, 4096 * 1024, touud - (4096 * 1024)); ram_resource(dev, 7, 4096 * 1024, touud - (4096 * 1024));
printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", printk(BIOS_INFO, "Available memory above 4GB: %lluM\n",
(touud >> 10) - 4096); (touud >> 10) - 4096);
} }
@ -152,12 +155,12 @@ static void mch_domain_read_resources(struct device *dev)
printk(BIOS_DEBUG, "Adding UMA memory area base=0x%llx " printk(BIOS_DEBUG, "Adding UMA memory area base=0x%llx "
"size=0x%llx\n", ((u64)tomk) << 10, ((u64)uma_sizek) << 10); "size=0x%llx\n", ((u64)tomk) << 10, ((u64)uma_sizek) << 10);
/* Don't use uma_resource() as our UMA touches the PCI hole. */ /* Don't use uma_resource() as our UMA touches the PCI hole. */
fixed_mem_resource(dev, 6, tomk, uma_sizek, IORESOURCE_RESERVE); fixed_mem_resource(dev, 8, tomk, uma_sizek, IORESOURCE_RESERVE);
if (decode_pcie_bar(&pcie_config_base, &pcie_config_size)) { if (decode_pcie_bar(&pcie_config_base, &pcie_config_size)) {
printk(BIOS_DEBUG, "Adding PCIe config bar base=0x%08x " printk(BIOS_DEBUG, "Adding PCIe config bar base=0x%08x "
"size=0x%x\n", pcie_config_base, pcie_config_size); "size=0x%x\n", pcie_config_base, pcie_config_size);
fixed_mem_resource(dev, 7, pcie_config_base >> 10, fixed_mem_resource(dev, 9, pcie_config_base >> 10,
pcie_config_size >> 10, IORESOURCE_RESERVE); pcie_config_size >> 10, IORESOURCE_RESERVE);
} }
} }
@ -167,7 +170,7 @@ static void mch_domain_set_resources(struct device *dev)
struct resource *resource; struct resource *resource;
int i; int i;
for (i = 3; i < 8; ++i) { for (i = 3; i <= 9; ++i) {
/* Report read resources. */ /* Report read resources. */
resource = probe_resource(dev, i); resource = probe_resource(dev, i);
if (resource) if (resource)