GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/intel/wifi: Drop call to pci_dev_init 

`pci_dev_init()` is used to load and run option ROM on VGA class
devices (PCI_CLASS_DISPLAY_VGA). WiFi device is not a VGA class device
and hence the call to `pci_dev_init()` is not required. This change
drops the call to `pci_dev_init()` from `wifi_pci_dev_init()` in Intel
WiFi driver.

BUG=b:169802515
BRANCH=zork

Change-Id: I6588ea0a5c848904088d05fd1cbdf677b2dc8ea9
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46029
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
This commit is contained in:
Furquan Shaikh 2020-10-03 14:57:20 -07:00
parent 7cb103461a
commit 58d39d07a1
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/drivers/intel/wifi/wifi.c
View File

@ -63,8 +63,6 @@ static void intel_wifi_fill_ssdt(const struct device *dev)
static void wifi_pci_dev_init(struct device *dev) static void wifi_pci_dev_init(struct device *dev)
{ {
pci_dev_init(dev);
if (CONFIG(ELOG)) { if (CONFIG(ELOG)) {
uint32_t val; uint32_t val;
val = pci_read_config16(dev, PMCS_DR); val = pci_read_config16(dev, PMCS_DR);