GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Various small fixes (trivial). 

- Add missing contributors to the README.

 - Drop obsolete -D option from manpage.

 - Only list contributors who added non-trivial amounts of code as copyright
   holders (and do not list those who merely provided register dump support
   for Super I/Os). Those contributors are still listed in the README,
   of course. See discussion in the thread starting at
   http://www.linuxbios.org/pipermail/linuxbios/2007-October/025516.html

 - Make a function static.

 - Fix incorrect URL in code comment. Drop obsolete comments.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@2992 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Uwe Hermann 2007-11-29 02:43:50 +00:00
parent 8e290d38e4
commit 59b99d9071
5 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
util/superiotool/README
View File

@ -87,10 +87,13 @@ Contributors
Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
David Hendricks <david.hendricks@gmail.com>
Frieder Ferlemann <Frieder.Ferlemann@web.de>
Idwer Vollering <idwer_v@hotmail.com>
Rasmus Wiman <rasmus@wiman.org>
Robinson P. Tryon <bishop.robinson@gmail.com>
Ronald Minnich <rminnich@gmail.com>
Stefan Reinauer <stepan@coresystems.de>
Ulf Jordan <jordan@chalmers.se>
Uwe Hermann <uwe@hermann-uwe.de>
Ward Vandewege <ward@gnu.org>

2
util/superiotool/smsc.c
View File

@ -326,7 +326,7 @@ static const struct superio_registers reg_table[] = {
{EOT}}},
{0x6e, "LPC47B387", { /* TODO: Not yet in sensors-detect */
/* Found in the HP Compaq Business Desktop d530 Series */
/* http://thread.gmane.org/gmane.linux.bios/26648 */
/* http://article.gmane.org/gmane.linux.bios/27192 */
/* We cannot find a public datasheet for this Super I/O. */
{EOT}}},
{0x6f, "LPC47B397", {

4
util/superiotool/superiotool.8
View File

@ -24,8 +24,8 @@ The list of supported Super I/O chips is available at:
If no command line option is specified,
.B superiotool
merely tries to detect the Super I/O chip.
You must use either the
.BR "\-d" " or the " "\-D"
You must use the
.B "\-d"
option to dump the Super I/O register contents.
.TP
.B "\-d, \-\-dump"

2
util/superiotool/superiotool.c
View File

@ -115,7 +115,7 @@ static void dump_regs(const struct superio_registers reg_table[],
printf(" NA");
else if (idx[k] == RSVD)
printf(" RR");
else if (idx[k] == MISC) /* TODO */
else if (idx[k] == MISC)
printf(" MM");
else
printf(" %02x", idx[k]);

6
util/superiotool/winbond.c
View File

@ -2,7 +2,6 @@
* This file is part of the superiotool project.
*
* Copyright (C) 2007 Uwe Hermann <uwe@hermann-uwe.de>
* Copyright (C) 2007 Rasmus Wiman <rasmus@wiman.org>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@ -389,7 +388,7 @@ static void enter_conf_mode_winbond_86(uint16_t port)
outb(0x86, port);
}
void probe_idregs_winbond_helper(const char *init, uint16_t port)
static void probe_idregs_winbond_helper(const char *init, uint16_t port)
{
uint16_t id;
uint8_t devid, rev, olddevid;
@ -425,14 +424,11 @@ void probe_idregs_winbond_helper(const char *init, uint16_t port)
get_superio_name(reg_table, id), devid, rev, port);
chip_found = 1;
/* TODO: Special notes in dump output for the MISC entries. */
dump_superio("Winbond", reg_table, port, id);
}
void probe_idregs_winbond(uint16_t port)
{
/* TODO: Not all init sequences are valid for all ports. */
enter_conf_mode_winbond_88(port);
probe_idregs_winbond_helper("(init=0x88) ", port);
exit_conf_mode_winbond_fintek_ite_8787(port);