GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

checkpatch: fine tune checks 

Fine tune the following two checks:

- Check for incorrect file permissions
  This one had a linux path hard coded, so it would choke on
  some commits unnecessarily.
- FILE_PATH_CHANGES seems to not be working correctly. It will
  choke on added / deleted files even if the MAINTAINERS file
  is touched. Hence, switch from WARN to CHK (as WARN currently
  blocks commits as well)

Change-Id: I9fccfbd75e94f420de45cf8b58071e3198065cf3
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/10123
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Stefan Reinauer 2015-05-06 11:10:18 -07:00 committed by Patrick Georgi
parent 023e829423
commit 59c2c8b079
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
util/lint/checkpatch.pl
View File

@ -2069,7 +2069,8 @@ sub process {
# Check for incorrect file permissions # Check for incorrect file permissions
if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
my $permhere = $here . "FILE: $realfile\n"; my $permhere = $here . "FILE: $realfile\n";
if ($realfile !~ m@scripts/@ && if ($realfile !~ m@util/lint/@ &&
$realfile !~ m@util/scripts/@ &&
$realfile !~ /\.(py|pl|awk|sh)$/) { $realfile !~ /\.(py|pl|awk|sh)$/) {
ERROR("EXECUTE_PERMISSIONS", ERROR("EXECUTE_PERMISSIONS",
"do not set execute permissions for source files\n" . $permhere); "do not set execute permissions for source files\n" . $permhere);
@ -2194,7 +2195,7 @@ sub process {
($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ && ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
(defined($1) || defined($2))))) { (defined($1) || defined($2))))) {
$reported_maintainer_file = 1; $reported_maintainer_file = 1;
WARN("FILE_PATH_CHANGES", CHK("FILE_PATH_CHANGES",
"added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr); "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
} }