soc/amd/{cezanne,picasso,stoney,common}: Don't clear PM1 on resume
According to https://uefi.org/specs/ACPI/6.4/04_ACPI_Hardware_Specification/ACPI_Hardware_Specification.html#pm1-event-grouping > For ACPI/legacy systems, when transitioning from the legacy to the G0 > working state this register is cleared by platform firmware prior to > setting the SCI_EN bit (and thus passing control to OSPM). For ACPI > only platforms (where SCI_EN is always set), when transitioning from > either the mechanical off (G3) or soft-off state to the G0 working > state this register is cleared prior to entering the G0 working state. This means we don't want to clear the PM1 register on resume. By clearing it the linux kernel can't correctly increment the wake count when the power button is pressed. The AMD platforms implement the _SWS ACPI methods, but the linux kernel doesn't actually use these methods. BUG=b:172021431 TEST=suspend zork and push power button and verify power button wake_count increments. Verified other wake sources still work. Signed-off-by: Raul E Rangel <rrangel@chromium.org> Change-Id: Iaa886540d90f4751d14837c1485ef50ceca48561 Reviewed-on: https://review.coreboot.org/c/coreboot/+/59929 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
parent
105495f37e
commit
59d64f06be
|
@ -199,7 +199,6 @@ void fch_init(void *chip_info)
|
|||
|
||||
acpi_pm_gpe_add_events_print_events();
|
||||
gpio_add_events();
|
||||
acpi_clear_pm_gpe_status();
|
||||
|
||||
gpp_clk_setup();
|
||||
fch_clk_output_48Mhz();
|
||||
|
|
|
@ -41,6 +41,8 @@ static void soc_finalize(void *unused)
|
|||
finalize_cores();
|
||||
|
||||
if (!acpi_is_wakeup_s3()) {
|
||||
acpi_clear_pm_gpe_status();
|
||||
|
||||
if (CONFIG(HAVE_SMI_HANDLER))
|
||||
acpi_disable_sci();
|
||||
else
|
||||
|
|
|
@ -225,8 +225,6 @@ void fch_init(void *chip_info)
|
|||
acpi_pm_gpe_add_events_print_events();
|
||||
gpio_add_events();
|
||||
|
||||
acpi_clear_pm_gpe_status();
|
||||
|
||||
al2ahb_clock_gate();
|
||||
|
||||
gpp_clk_setup();
|
||||
|
|
|
@ -214,6 +214,5 @@ static void migrate_power_state(int is_recovery)
|
|||
acpi_fill_pm_gpe_state(&state->gpe_state);
|
||||
acpi_pm_gpe_add_events_print_events();
|
||||
}
|
||||
acpi_clear_pm_gpe_status();
|
||||
}
|
||||
ROMSTAGE_CBMEM_INIT_HOOK(migrate_power_state)
|
||||
|
|
Loading…
Reference in New Issue