From 5a090bf1257b6a5464ac21527d350b4aa13097ab Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Fri, 2 Apr 2021 17:24:34 -0700 Subject: [PATCH] verstage: Add debug print when returning from verstage RETURN_FROM_VERSTAGE is a somewhat tricky construct that we don't normally do otherwise in coreboot. While it works remarkably well in general, new development can lead to unintentional interactions with confusing results. This patch adds a debug print to the verstage right before returning to the bootblock so that it's obvious this happens, because otherwise in some cases the last printout in the verstage is about some TPM commands which can be misleading when execution hangs after that point. Signed-off-by: Julius Werner Change-Id: I9ca68a32d7a50c95d9a6948d35816fee583611bc Reviewed-on: https://review.coreboot.org/c/coreboot/+/52086 Reviewed-by: Furquan Shaikh Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- src/security/vboot/verstage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security/vboot/verstage.c b/src/security/vboot/verstage.c index d2a9705546..d785e0e6ac 100644 --- a/src/security/vboot/verstage.c +++ b/src/security/vboot/verstage.c @@ -19,6 +19,7 @@ void main(void) if (CONFIG(VBOOT_RETURN_FROM_VERSTAGE)) { verstage_main(); + printk(BIOS_DEBUG, "VBOOT: Returning from verstage.\n"); } else { run_romstage(); hlt();