From 5a62427e1451bb5e6e2c397b4c5950fac90cda1c Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Tue, 11 Feb 2020 16:02:11 +0100 Subject: [PATCH] nb/intel/sandybridge/acpi: Fix MMCONF size computation Calculate the correct MMCONF size, which was only correct for 256MiB, but not for smaller values. Tested on HP Z220: Fixes "Not using MMCONF" warning in dmesg. Change-Id: I986681126637c28f6442ab7c34acea5bb58ea3d2 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/38830 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Jonathan Kollasch --- src/northbridge/intel/sandybridge/acpi/sandybridge.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/northbridge/intel/sandybridge/acpi/sandybridge.asl b/src/northbridge/intel/sandybridge/acpi/sandybridge.asl index 3181fc0a3f..0670c7b0a6 100644 --- a/src/northbridge/intel/sandybridge/acpi/sandybridge.asl +++ b/src/northbridge/intel/sandybridge/acpi/sandybridge.asl @@ -62,7 +62,7 @@ Device (PDRC) XBR0 = \_SB.PCI0.MCHC.PXBR << 26 CreateDwordField (PDRS, ^PCIX._LEN, XSZ0) - XSZ0 = 0x10000000 << \_SB.PCI0.MCHC.PXSZ + XSZ0 = 0x10000000 >> \_SB.PCI0.MCHC.PXSZ Return(PDRS) }