GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

southbridge: Drop print_ implementation from non-romcc boards 

Because we had no stack on romcc boards, we had a separate, not as
powerful clone of printk: print_*. Back in the day, like more than
half a decade ago, we migrated a lot of boards to printk, but we never
cleaned up the existing code to be consistent. instead, we worked around
the problem with a very messy console.h (nowadays the mess is hidden in
romstage_console.c and early_print.h)
This patch cleans up the southbridge code to use printk() on all non-ROMCC
boards.

Change-Id: I312406257e66bbdc3940e206b5256460559a2c98
Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-on: http://review.coreboot.org/8110
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Stefan Reinauer 2015-01-05 13:01:01 -08:00 committed by Stefan Reinauer
parent 65b72ab55d
commit 5ab52ddc3d
41 changed files with 143 additions and 181 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/southbridge/amd/amd8111/early_smbus.c
View File

@ -23,7 +23,7 @@ static void enable_smbus(void)
/* clear any lingering errors, so the transaction will run */ /* clear any lingering errors, so the transaction will run */
outw(inw(SMBUS_IO_BASE + SMBGSTATUS), SMBUS_IO_BASE + SMBGSTATUS); outw(inw(SMBUS_IO_BASE + SMBGSTATUS), SMBUS_IO_BASE + SMBGSTATUS);
print_spew("SMBus controller enabled\n"); printk(BIOS_SPEW, "SMBus controller enabled\n");
} }
static inline int smbus_recv_byte(unsigned device) static inline int smbus_recv_byte(unsigned device)

12
src/southbridge/amd/cs5535/early_setup.c
View File

@ -127,19 +127,19 @@ static void cs5535_early_setup(void)
msr = rdmsr(GLCP_SYS_RSTPLL); msr = rdmsr(GLCP_SYS_RSTPLL);
if (msr.lo & (0x3f << 26)) { if (msr.lo & (0x3f << 26)) {
/* PLL is already set and we are reboot from PLL reset */ /* PLL is already set and we are reboot from PLL reset */
print_debug("reboot from BIOS reset\n"); printk(BIOS_DEBUG, "reboot from BIOS reset\n");
return; return;
} }
print_debug("Setup idsel\n"); printk(BIOS_DEBUG, "Setup idsel\n");
cs5535_setup_idsel(); cs5535_setup_idsel();
print_debug("Setup iobase\n"); printk(BIOS_DEBUG, "Setup iobase\n");
cs5535_usb_swapsif(); cs5535_usb_swapsif();
cs5535_setup_iobase(); cs5535_setup_iobase();
print_debug("Setup gpio\n"); printk(BIOS_DEBUG, "Setup gpio\n");
cs5535_setup_gpio(); cs5535_setup_gpio();
print_debug("Setup cis_mode\n"); printk(BIOS_DEBUG, "Setup cis_mode\n");
cs5535_setup_cis_mode(); cs5535_setup_cis_mode();
print_debug("Setup smbus\n"); printk(BIOS_DEBUG, "Setup smbus\n");
cs5535_enable_smbus(); cs5535_enable_smbus();
dummy(); dummy();
} }

12
src/southbridge/amd/cs5536/early_setup.c
View File

@ -258,18 +258,18 @@ static void cs5536_early_setup(void)
msr = rdmsr(GLCP_SYS_RSTPLL); msr = rdmsr(GLCP_SYS_RSTPLL);
if (msr.lo & (0x3f << 26)) { if (msr.lo & (0x3f << 26)) {
/* PLL is already set and we are reboot from PLL reset */ /* PLL is already set and we are reboot from PLL reset */
//print_debug("reboot from BIOS reset\n"); //printk(BIOS_DEBUG, "reboot from BIOS reset\n");
return; return;
} }
//print_debug("Setup idsel\n"); //printk(BIOS_DEBUG, "Setup idsel\n");
cs5536_setup_idsel(); cs5536_setup_idsel();
//print_debug("Setup iobase\n"); //printk(BIOS_DEBUG, "Setup iobase\n");
cs5536_usb_swapsif(); cs5536_usb_swapsif();
cs5536_setup_iobase(); cs5536_setup_iobase();
//print_debug("Setup gpio\n"); //printk(BIOS_DEBUG, "Setup gpio\n");
cs5536_setup_gpio(); cs5536_setup_gpio();
//print_debug("Setup smbus\n"); //printk(BIOS_DEBUG, "Setup smbus\n");
cs5536_enable_smbus(); cs5536_enable_smbus();
//print_debug("Setup power button\n"); //printk(BIOS_DEBUG, "Setup power button\n");
cs5536_setup_power_button(); cs5536_setup_power_button();
} }

6
src/southbridge/amd/cs5536/smbus.c
View File

@ -182,11 +182,7 @@ unsigned char do_smbus_read_byte(unsigned smbus_io_base,
return smbus_get_result(smbus_io_base); return smbus_get_result(smbus_io_base);
err: err:
print_debug("SMBUS READ ERROR:"); printk(BIOS_DEBUG, "SMBUS READ ERROR: %02x device: %02x\n", error, device);
print_debug_hex8(error);
print_debug(" device:");
print_debug_hex8(device);
print_debug("\n");
/* stop, clean up the error, and leave */ /* stop, clean up the error, and leave */
smbus_stop_condition(smbus_io_base); smbus_stop_condition(smbus_io_base);
outb(inb(smbus_io_base + SMB_STS), smbus_io_base + SMB_STS); outb(inb(smbus_io_base + SMB_STS), smbus_io_base + SMB_STS);

2
src/southbridge/broadcom/bcm5785/early_smbus.c
View File

@ -31,7 +31,7 @@ static void enable_smbus(void)
die("SMBUS controller not found\n"); die("SMBUS controller not found\n");
} }
print_debug("SMBus controller enabled\n"); printk(BIOS_DEBUG, "SMBus controller enabled\n");
/* set smbus iobase */ /* set smbus iobase */
pci_write_config32(dev, 0x90, SMBUS_IO_BASE | 1); pci_write_config32(dev, 0x90, SMBUS_IO_BASE | 1);
/* Set smbus iospace enable */ /* Set smbus iospace enable */

2
src/southbridge/intel/bd82x6x/early_smbus.c
View File

@ -52,7 +52,7 @@ void enable_smbus(void)
/* Clear any lingering errors, so transactions can run. */ /* Clear any lingering errors, so transactions can run. */
outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
print_debug("SMBus controller enabled.\n"); printk(BIOS_DEBUG, "SMBus controller enabled.\n");
} }
int smbus_read_byte(unsigned device, unsigned address) int smbus_read_byte(unsigned device, unsigned address)

4
src/southbridge/intel/esb6300/early_smbus.c
View File

@ -6,7 +6,7 @@ static void enable_smbus(void)
{ {
device_t dev = PCI_DEV(0x0, 0x1f, 0x3); device_t dev = PCI_DEV(0x0, 0x1f, 0x3);
print_spew("SMBus controller enabled\n"); printk(BIOS_SPEW, "SMBus controller enabled\n");
pci_write_config32(dev, 0x20, SMBUS_IO_BASE | 1); pci_write_config32(dev, 0x20, SMBUS_IO_BASE | 1);
pci_write_config8(dev, 0x40, 1); pci_write_config8(dev, 0x40, 1);
pci_write_config8(dev, 0x4, 1); pci_write_config8(dev, 0x4, 1);
@ -91,7 +91,7 @@ static int smbus_write_block(unsigned device, unsigned length, unsigned cmd,
SMBUS_IO_BASE + SMBHSTSTAT); SMBUS_IO_BASE + SMBHSTSTAT);
} }
print_debug("SMBUS Block complete\n"); printk(BIOS_DEBUG, "SMBUS Block complete\n");
return 0; return 0;
} }
#endif #endif

2
src/southbridge/intel/fsp_bd82x6x/early_smbus.c
View File

@ -97,7 +97,7 @@ void enable_smbus(void)
/* Clear any lingering errors, so transactions can run. */ /* Clear any lingering errors, so transactions can run. */
outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
print_debug("SMBus controller enabled.\n"); printk(BIOS_DEBUG, "SMBus controller enabled.\n");
} }
/** \brief generic smbus helper function to read & write to the smbus /** \brief generic smbus helper function to read & write to the smbus

2
src/southbridge/intel/fsp_rangeley/early_smbus.c
View File

@ -52,7 +52,7 @@ void enable_smbus(void)
/* Clear any lingering errors, so transactions can run. */ /* Clear any lingering errors, so transactions can run. */
outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
print_debug("SMBus controller enabled.\n"); printk(BIOS_DEBUG, "SMBus controller enabled.\n");
} }
int smbus_read_byte(unsigned device, unsigned address) int smbus_read_byte(unsigned device, unsigned address)

2
src/southbridge/intel/i3100/early_smbus.c
View File

@ -26,7 +26,7 @@ static void enable_smbus(void)
{ {
device_t dev = PCI_DEV(0x0, 0x1f, 0x3); device_t dev = PCI_DEV(0x0, 0x1f, 0x3);
print_spew("SMBus controller enabled\n"); printk(BIOS_SPEW, "SMBus controller enabled\n");
pci_write_config32(dev, 0x20, SMBUS_IO_BASE | 1); pci_write_config32(dev, 0x20, SMBUS_IO_BASE | 1);
pci_write_config8(dev, 0x40, 1); pci_write_config8(dev, 0x40, 1);
pci_write_config8(dev, 0x4, 1); pci_write_config8(dev, 0x4, 1);

4
src/southbridge/intel/i82371eb/smbus.h
View File

@ -104,9 +104,7 @@ int do_smbus_read_byte(unsigned smbus_io_base, unsigned device, unsigned address
if (status_register & 0x04) { if (status_register & 0x04) {
#if 0 #if 0
print_debug("Read fail "); printk(BIOS_DEBUG, "Read fail %04x\n", status_register);
print_debug_hex16(status_register);
print_debug("\n");
#endif #endif
return SMBUS_ERROR; return SMBUS_ERROR;
} }

2
src/southbridge/intel/i82801ax/early_smbus.c
View File

@ -50,7 +50,7 @@ void enable_smbus(void)
/* Clear any lingering errors, so transactions can run. */ /* Clear any lingering errors, so transactions can run. */
outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
print_debug("SMBus controller enabled\n"); printk(BIOS_DEBUG, "SMBus controller enabled\n");
} }
int smbus_read_byte(u8 device, u8 address) int smbus_read_byte(u8 device, u8 address)

2
src/southbridge/intel/i82801bx/early_smbus.c
View File

@ -50,7 +50,7 @@ void enable_smbus(void)
/* Clear any lingering errors, so transactions can run. */ /* Clear any lingering errors, so transactions can run. */
outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
print_debug("SMBus controller enabled\n"); printk(BIOS_DEBUG, "SMBus controller enabled\n");
} }
int smbus_read_byte(u8 device, u8 address) int smbus_read_byte(u8 device, u8 address)

2
src/southbridge/intel/i82801cx/early_smbus.c
View File

@ -5,7 +5,7 @@ static void enable_smbus(void)
{ {
device_t dev = PCI_DEV(0x0, 0x1f, 0x3); device_t dev = PCI_DEV(0x0, 0x1f, 0x3);
print_debug("SMBus controller enabled\n"); printk(BIOS_DEBUG, "SMBus controller enabled\n");
/* set smbus iobase */ /* set smbus iobase */
pci_write_config32(dev, SMB_BASE, SMBUS_IO_BASE | PCI_BASE_ADDRESS_SPACE_IO); pci_write_config32(dev, SMB_BASE, SMBUS_IO_BASE | PCI_BASE_ADDRESS_SPACE_IO);
/* Set smbus enable */ /* Set smbus enable */

14
src/southbridge/intel/i82801dx/early_smbus.c
View File

@ -28,7 +28,7 @@ void enable_smbus(void)
{ {
device_t dev = PCI_DEV(0x0, 0x1f, 0x3); device_t dev = PCI_DEV(0x0, 0x1f, 0x3);
print_debug("SMBus controller enabled\n"); printk(BIOS_DEBUG, "SMBus controller enabled\n");
/* set smbus iobase */ /* set smbus iobase */
pci_write_config32(dev, 0x20, SMBUS_IO_BASE | 1); pci_write_config32(dev, 0x20, SMBUS_IO_BASE | 1);
/* Set smbus enable */ /* Set smbus enable */
@ -104,9 +104,9 @@ int smbus_read_byte(unsigned device, unsigned address)
unsigned char global_status_register; unsigned char global_status_register;
unsigned char byte; unsigned char byte;
/* print_err("smbus_read_byte\n"); */ /* printk(BIOS_ERR, "smbus_read_byte\n"); */
if (smbus_wait_until_ready() < 0) { if (smbus_wait_until_ready() < 0) {
print_err("SMBUS not ready (-2)\n"); printk(BIOS_ERR, "SMBUS not ready (-2)\n");
return -2; return -2;
} }
@ -132,13 +132,13 @@ int smbus_read_byte(unsigned device, unsigned address)
SMBUS_IO_BASE + SMBHSTCTL); SMBUS_IO_BASE + SMBHSTCTL);
/* poll for it to start */ /* poll for it to start */
if (smbus_wait_until_active() < 0) { if (smbus_wait_until_active() < 0) {
print_err("SMBUS not active (-4)\n"); printk(BIOS_ERR, "SMBUS not active (-4)\n");
return -4; return -4;
} }
/* poll for transaction completion */ /* poll for transaction completion */
if (smbus_wait_until_done() < 0) { if (smbus_wait_until_done() < 0) {
print_err("SMBUS not completed (-3)\n"); printk(BIOS_ERR, "SMBUS not completed (-3)\n");
return -3; return -3;
} }
@ -148,10 +148,10 @@ int smbus_read_byte(unsigned device, unsigned address)
byte = inb(SMBUS_IO_BASE + SMBHSTDAT0); byte = inb(SMBUS_IO_BASE + SMBHSTDAT0);
if (global_status_register != 2) { if (global_status_register != 2) {
//print_spew("%s: no device (%02x, %02x)\n", __func__, device, address); //printk(BIOS_SPEW, "%s: no device (%02x, %02x)\n", __func__, device, address);
return -1; return -1;
} }
//print_debug("%s: %02x@%02x = %02x\n", __func__, device, address, byte); //printk(BIOS_DEBUG, "%s: %02x@%02x = %02x\n", __func__, device, address, byte);
return byte; return byte;
} }

8
src/southbridge/intel/i82801ex/early_smbus.c
View File

@ -6,10 +6,10 @@ static void enable_smbus(void)
{ {
device_t dev = PCI_DEV(0x0, 0x1f, 0x3); device_t dev = PCI_DEV(0x0, 0x1f, 0x3);
print_spew("SMBus controller enabled\n"); printk(BIOS_SPEW, "SMBus controller enabled\n");
pci_write_config32(dev, 0x20, SMBUS_IO_BASE | 1); pci_write_config32(dev, 0x20, SMBUS_IO_BASE | 1);
print_debug_hex32(pci_read_config32(dev, 0x20)); printk(BIOS_DEBUG, "%08x", pci_read_config32(dev, 0x20));
/* Set smbus enable */ /* Set smbus enable */
pci_write_config8(dev, 0x40, 1); pci_write_config8(dev, 0x40, 1);
/* Set smbus iospace enable */ /* Set smbus iospace enable */
@ -36,7 +36,7 @@ static void smbus_write_byte(unsigned device, unsigned address, unsigned char va
return; return;
} }
print_debug("Unimplemented smbus_write_byte() called.\n"); printk(BIOS_DEBUG, "Unimplemented smbus_write_byte() called.\n");
#if 0 #if 0
/* setup transaction */ /* setup transaction */
@ -124,7 +124,7 @@ static int smbus_write_block(unsigned device, unsigned length, unsigned cmd,
SMBUS_IO_BASE + SMBHSTSTAT); SMBUS_IO_BASE + SMBHSTSTAT);
} }
print_debug("SMBUS Block complete\n"); printk(BIOS_DEBUG, "SMBUS Block complete\n");
return 0; return 0;
} }
#endif #endif

2
src/southbridge/intel/i82801gx/early_smbus.c
View File

@ -52,7 +52,7 @@ void enable_smbus(void)
/* Clear any lingering errors, so transactions can run. */ /* Clear any lingering errors, so transactions can run. */
outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
print_debug("SMBus controller enabled.\n"); printk(BIOS_DEBUG, "SMBus controller enabled.\n");
} }
int smbus_read_byte(unsigned device, unsigned address) int smbus_read_byte(unsigned device, unsigned address)

2
src/southbridge/intel/i82801ix/early_smbus.c
View File

@ -53,7 +53,7 @@ void enable_smbus(void)
/* Clear any lingering errors, so transactions can run. */ /* Clear any lingering errors, so transactions can run. */
outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
print_debug("SMBus controller enabled.\n"); printk(BIOS_DEBUG, "SMBus controller enabled.\n");
} }
int smbus_read_byte(unsigned device, unsigned address) int smbus_read_byte(unsigned device, unsigned address)

2
src/southbridge/intel/ibexpeak/early_smbus.c
View File

@ -52,7 +52,7 @@ void enable_smbus(void)
/* Clear any lingering errors, so transactions can run. */ /* Clear any lingering errors, so transactions can run. */
outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
print_debug("SMBus controller enabled.\n"); printk(BIOS_DEBUG, "SMBus controller enabled.\n");
} }
int smbus_read_byte(unsigned device, unsigned address) int smbus_read_byte(unsigned device, unsigned address)

2
src/southbridge/intel/lynxpoint/early_smbus.c
View File

@ -52,7 +52,7 @@ void enable_smbus(void)
/* Clear any lingering errors, so transactions can run. */ /* Clear any lingering errors, so transactions can run. */
outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
print_debug("SMBus controller enabled.\n"); printk(BIOS_DEBUG, "SMBus controller enabled.\n");
} }
int smbus_read_byte(unsigned device, unsigned address) int smbus_read_byte(unsigned device, unsigned address)

2
src/southbridge/intel/sch/early_smbus.c
View File

@ -52,7 +52,7 @@ void enable_smbus(void)
/* Clear any lingering errors, so transactions can run. */ /* Clear any lingering errors, so transactions can run. */
outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS_IO_BASE + SMBHSTSTAT), SMBUS_IO_BASE + SMBHSTSTAT);
print_debug("SMBus controller enabled.\n"); printk(BIOS_DEBUG, "SMBus controller enabled.\n");
} }
int smbus_read_byte(unsigned device, unsigned address) int smbus_read_byte(unsigned device, unsigned address)

2
src/southbridge/nvidia/ck804/early_smbus.c
View File

@ -54,7 +54,7 @@ void enable_smbus(void)
outb(inb(SMBUS_BASE(0) + SMBHSTSTAT), SMBUS_BASE(0) + SMBHSTSTAT); outb(inb(SMBUS_BASE(0) + SMBHSTSTAT), SMBUS_BASE(0) + SMBHSTSTAT);
outb(inb(SMBUS_BASE(1) + SMBHSTSTAT), SMBUS_BASE(1) + SMBHSTSTAT); outb(inb(SMBUS_BASE(1) + SMBHSTSTAT), SMBUS_BASE(1) + SMBHSTSTAT);
print_debug("SMBus controller enabled\n"); printk(BIOS_DEBUG, "SMBus controller enabled\n");
} }
int ck804_smbus_read_byte(unsigned bus, unsigned device, unsigned address) int ck804_smbus_read_byte(unsigned bus, unsigned device, unsigned address)

4
src/southbridge/nvidia/mcp55/early_setup_car.c
View File

@ -392,9 +392,7 @@ static int mcp55_early_setup_x(void)
} }
out: out:
print_debug("mcp55_num:"); printk(BIOS_DEBUG, "mcp55_num: %02x\n", mcp55_num);
print_debug_hex8(mcp55_num);
print_debug("\n");
mcp55_early_set_port(mcp55_num, busn, devn, io_base); mcp55_early_set_port(mcp55_num, busn, devn, io_base);
mcp55_early_setup(mcp55_num, busn, devn, io_base, pci_e_x); mcp55_early_setup(mcp55_num, busn, devn, io_base, pci_e_x);

17
src/southbridge/sis/sis966/aza.c
View File

@ -244,7 +244,7 @@ static void aza_init(struct device *dev)
struct resource *res; struct resource *res;
u32 codec_mask; u32 codec_mask;
print_debug("AZALIA_INIT:---------->\n"); printk(BIOS_DEBUG, "AZALIA_INIT:---------->\n");
//-------------- enable AZA (SiS7502) ------------------------- //-------------- enable AZA (SiS7502) -------------------------
{ {
@ -269,19 +269,16 @@ static void aza_init(struct device *dev)
{ {
int i; int i;
print_debug("****** Azalia PCI config ******"); printk(BIOS_DEBUG, "****** Azalia PCI config ******");
print_debug("\n 03020100 07060504 0B0A0908 0F0E0D0C"); printk(BIOS_DEBUG, "\n 03020100 07060504 0B0A0908 0F0E0D0C");
for(i=0;i<0xff;i+=4){ for(i=0;i<0xff;i+=4){
if((i%16)==0){ if((i%16)==0){
print_debug("\n"); printk(BIOS_DEBUG, "\n%02x: ", i);
print_debug_hex8(i);
print_debug(": ");
} }
print_debug_hex32(pci_read_config32(dev,i)); printk(BIOS_DEBUG, "%08x ", pci_read_config32(dev,i));
print_debug(" ");
} }
print_debug("\n"); printk(BIOS_DEBUG, "\n");
} }
#endif #endif
@ -299,7 +296,7 @@ static void aza_init(struct device *dev)
codecs_init(base, codec_mask); codecs_init(base, codec_mask);
} }
print_debug("AZALIA_INIT:<----------\n"); printk(BIOS_DEBUG, "AZALIA_INIT:<----------\n");
} }
static void lpci_set_subsystem(device_t dev, unsigned vendor, unsigned device) static void lpci_set_subsystem(device_t dev, unsigned vendor, unsigned device)

22
src/southbridge/sis/sis966/early_smbus.c
View File

@ -138,23 +138,23 @@ static inline int do_smbus_read_byte(unsigned smbus_io_base, unsigned device, un
outb(0x12, smbus_io_base + 0x03); outb(0x12, smbus_io_base + 0x03);
smbus_delay(); smbus_delay();
int i,j; int i, j;
for(i=0;i<0x1000;i++) for(i = 0;i < 0x1000; i++)
{ {
if (inb(smbus_io_base + 0x00) != 0x08) if (inb(smbus_io_base + 0x00) != 0x08)
{ smbus_delay(); { smbus_delay();
for(j=0;j<0xFFFF;j++); for(j=0;j<0xFFFF;j++);
}
} }
};
global_status_register = inb(smbus_io_base + 0x00); global_status_register = inb(smbus_io_base + 0x00);
byte = inb(smbus_io_base + 0x08); byte = inb(smbus_io_base + 0x08);
if (global_status_register != 0x08) { // lose check, otherwise it should be 0 if (global_status_register != 0x08) { // lose check, otherwise it should be 0
print_debug("Fail");print_debug("\r\t"); printk(BIOS_DEBUG, "Fail\r\t");
return -1; return -1;
} }
print_debug("Success");print_debug("\r\t"); printk(BIOS_DEBUG, "Success\r\t");
return byte; return byte;
} }
@ -706,7 +706,7 @@ static void sis_init_stage2(void)
dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_SIS, PCI_DEVICE_ID_SIS_SIS966_SATA), 0); dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_SIS, PCI_DEVICE_ID_SIS_SIS966_SATA), 0);
if (!dev) if (!dev)
print_debug("SiS 1183 does not exist !!"); printk(BIOS_DEBUG, "SiS 1183 does not exist !!");
// SATA Set Mode // SATA Set Mode
pci_write_config8(dev, 0x90, (pci_read_config8(dev, 0x90)&0x3F) | 0x40); pci_write_config8(dev, 0x90, (pci_read_config8(dev, 0x90)&0x3F) | 0x40);

20
src/southbridge/sis/sis966/ide.c
View File

@ -100,7 +100,7 @@ static void ide_init(struct device *dev)
print_debug("IDE_INIT:---------->\n"); printk(BIOS_DEBUG, "IDE_INIT:---------->\n");
//-------------- enable IDE (SiS5513) ------------------------- //-------------- enable IDE (SiS5513) -------------------------
@ -149,22 +149,18 @@ print_debug("IDE_INIT:---------->\n");
{ {
int i; int i;
print_debug("****** IDE PCI config ******"); printk(BIOS_DEBUG, "****** IDE PCI config ******");
print_debug("\n 03020100 07060504 0B0A0908 0F0E0D0C"); printk(BIOS_DEBUG, "\n 03020100 07060504 0B0A0908 0F0E0D0C");
for(i=0;i<0xff;i+=4){ for(i=0;i<0xff;i+=4){
if((i%16)==0){ if((i%16)==0)
print_debug("\n"); printk(BIOS_DEBUG, "\n%02x: ", i);
print_debug_hex8(i); printk(BIOS_DEBUG, "%08x ", pci_read_config32(dev,i));
print_debug(": ");
}
print_debug_hex32(pci_read_config32(dev,i));
print_debug(" ");
} }
print_debug("\n"); printk(BIOS_DEBUG, "\n");
} }
#endif #endif
print_debug("IDE_INIT:<----------\n"); printk(BIOS_DEBUG, "IDE_INIT:<----------\n");
} }
static void lpci_set_subsystem(device_t dev, unsigned vendor, unsigned device) static void lpci_set_subsystem(device_t dev, unsigned vendor, unsigned device)

20
src/southbridge/sis/sis966/nic.c
View File

@ -241,7 +241,7 @@ static void nic_init(struct device *dev)
u32 base; u32 base;
struct resource *res; struct resource *res;
print_debug("NIC_INIT:---------->\n"); printk(BIOS_DEBUG, "NIC_INIT:---------->\n");
//-------------- enable NIC (SiS19x) ------------------------- //-------------- enable NIC (SiS19x) -------------------------
{ {
@ -312,19 +312,15 @@ static void nic_init(struct device *dev)
{ {
int i; int i;
print_debug("****** NIC PCI config ******"); printk(BIOS_DEBUG, "****** NIC PCI config ******");
print_debug("\n 03020100 07060504 0B0A0908 0F0E0D0C"); printk(BIOS_DEBUG, "\n 03020100 07060504 0B0A0908 0F0E0D0C");
for(i=0;i<0xff;i+=4){ for(i=0;i<0xff;i+=4){
if((i%16)==0){ if((i%16)==0)
print_debug("\n"); printk(BIOS_DEBUG, "\n%02x: ", i);
print_debug_hex8(i); printk(BIOS_DEBUG, "%08x ", pci_read_config32(dev,i));
print_debug(": ");
}
print_debug_hex32(pci_read_config32(dev,i));
print_debug(" ");
} }
print_debug("\n"); printk(BIOS_DEBUG, "\n");
} }
@ -332,7 +328,7 @@ static void nic_init(struct device *dev)
} }
print_debug("NIC_INIT:<----------\n"); printk(BIOS_DEBUG, "NIC_INIT:<----------\n");
return; return;

20
src/southbridge/sis/sis966/sata.c
View File

@ -116,7 +116,7 @@ static void sata_init(struct device *dev)
conf = dev->chip_info; conf = dev->chip_info;
print_debug("SATA_INIT:---------->\n"); printk(BIOS_DEBUG, "SATA_INIT:---------->\n");
//-------------- enable IDE (SiS1183) ------------------------- //-------------- enable IDE (SiS1183) -------------------------
{ {
@ -151,23 +151,19 @@ for (i=0;i<10;i++){
{ {
int i; int i;
print_debug("****** SATA PCI config ******"); printk(BIOS_DEBUG, "****** SATA PCI config ******");
print_debug("\n 03020100 07060504 0B0A0908 0F0E0D0C"); printk(BIOS_DEBUG, "\n 03020100 07060504 0B0A0908 0F0E0D0C");
for(i=0;i<0xff;i+=4){ for(i=0;i<0xff;i+=4){
if((i%16)==0){ if((i%16)==0)
print_debug("\n"); printk(BIOS_DEBUG, "\n%02x: ", i);
print_debug_hex8(i); printk(BIOS_DEBUG, "%08x ", pci_read_config32(dev,i));
print_debug(": ");
}
print_debug_hex32(pci_read_config32(dev,i));
print_debug(" ");
} }
print_debug("\n"); printk(BIOS_DEBUG, "\n");
} }
#endif #endif
print_debug("SATA_INIT:<----------\n"); printk(BIOS_DEBUG, "SATA_INIT:<----------\n");
} }

20
src/southbridge/sis/sis966/usb.c
View File

@ -55,7 +55,7 @@ uint8_t SiS_SiS7001_init[16][3]={
static void usb_init(struct device *dev) static void usb_init(struct device *dev)
{ {
print_debug("USB 1.1 INIT:---------->\n"); printk(BIOS_DEBUG, "USB 1.1 INIT:---------->\n");
//-------------- enable USB1.1 (SiS7001) ------------------------- //-------------- enable USB1.1 (SiS7001) -------------------------
{ {
@ -76,22 +76,18 @@ static void usb_init(struct device *dev)
{ {
int i; int i;
print_debug("****** USB 1.1 PCI config ******"); printk(BIOS_DEBUG, "****** USB 1.1 PCI config ******");
print_debug("\n 03020100 07060504 0B0A0908 0F0E0D0C"); printk(BIOS_DEBUG, "\n 03020100 07060504 0B0A0908 0F0E0D0C");
for(i=0;i<0xff;i+=4){ for(i=0;i<0xff;i+=4){
if((i%16)==0){ if((i%16)==0)
print_debug("\n"); printk(BIOS_DEBUG, "\n%02x: ", i);
print_debug_hex8(i); printk(BIOS_DEBUG, "%08x ", pci_read_config32(dev,i));
print_debug(": ");
}
print_debug_hex32(pci_read_config32(dev,i));
print_debug(" ");
} }
print_debug("\n"); printk(BIOS_DEBUG, "\n");
} }
#endif #endif
print_debug("USB 1.1 INIT:<----------\n"); printk(BIOS_DEBUG, "USB 1.1 INIT:<----------\n");
} }
static void lpci_set_subsystem(device_t dev, unsigned vendor, unsigned device) static void lpci_set_subsystem(device_t dev, unsigned vendor, unsigned device)

20
src/southbridge/sis/sis966/usb2.c
View File

@ -71,7 +71,7 @@ static void usb2_init(struct device *dev)
int i; int i;
u8 temp8; u8 temp8;
print_debug("USB 2.0 INIT:---------->\n"); printk(BIOS_DEBUG, "USB 2.0 INIT:---------->\n");
//-------------- enable USB2.0 (SiS7002) ---------------------- //-------------- enable USB2.0 (SiS7002) ----------------------
@ -95,21 +95,17 @@ static void usb2_init(struct device *dev)
//------------------------------------------------------------- //-------------------------------------------------------------
#if DEBUG_USB2 #if DEBUG_USB2
print_debug("****** USB 2.0 PCI config ******"); printk(BIOS_DEBUG, "****** USB 2.0 PCI config ******");
print_debug("\n 03020100 07060504 0B0A0908 0F0E0D0C"); printk(BIOS_DEBUG, "\n 03020100 07060504 0B0A0908 0F0E0D0C");
for(i=0;i<0xff;i+=4){ for(i=0;i<0xff;i+=4){
if((i%16)==0){ if((i%16)==0)
print_debug("\n"); printk(BIOS_DEBUG, "\n%02x: ", i);
print_debug_hex8(i); printk(BIOS_DEBUG, "%08x ", pci_read_config32(dev,i));
print_debug(": ");
}
print_debug_hex32(pci_read_config32(dev,i));
print_debug(" ");
} }
print_debug("\n"); printk(BIOS_DEBUG, "\n");
#endif #endif
print_debug("USB 2.0 INIT:<----------\n"); printk(BIOS_DEBUG, "USB 2.0 INIT:<----------\n");
} }
static void lpci_set_subsystem(device_t dev, unsigned vendor, unsigned device) static void lpci_set_subsystem(device_t dev, unsigned vendor, unsigned device)

2
src/southbridge/via/k8t890/bridge.c
View File

@ -26,7 +26,7 @@
static void bridge_enable(struct device *dev) static void bridge_enable(struct device *dev)
{ {
u8 tmp; u8 tmp;
print_debug("B188 device dump\n"); printk(BIOS_DEBUG, "B188 device dump\n");
/* VIA recommends this, sorry no known info. */ /* VIA recommends this, sorry no known info. */

8
src/southbridge/via/k8t890/ctrl.c
View File

@ -152,7 +152,7 @@ static void vt8237r_vlink_init(struct device *dev)
static void ctrl_init(struct device *dev) static void ctrl_init(struct device *dev)
{ {
print_debug("K8x8xx: Initializing V-Link to VT8237R sb: "); printk(BIOS_DEBUG, "K8x8xx: Initializing V-Link to VT8237R sb: ");
/* TODO: Fix some ordering issue for V-link set Rx77[6] and PCI1_Rx4F[0] /* TODO: Fix some ordering issue for V-link set Rx77[6] and PCI1_Rx4F[0]
should to 1 */ should to 1 */
@ -172,11 +172,11 @@ static void ctrl_init(struct device *dev)
vt8237r_vlink_init(dev); vt8237r_vlink_init(dev);
k8x8xx_vt8237r_cfg(dev, devsb); k8x8xx_vt8237r_cfg(dev, devsb);
} else { } else {
print_debug("VT8237R LPC not found !\n"); printk(BIOS_DEBUG, "VT8237R LPC not found !\n");
return; return;
} }
print_debug(" Done\n"); printk(BIOS_DEBUG, " Done\n");
print_debug(" VIA_X_7 device dump:\n"); printk(BIOS_DEBUG, " VIA_X_7 device dump:\n");
dump_south(dev); dump_south(dev);
} }

2
src/southbridge/via/k8t890/dram.c
View File

@ -66,7 +66,7 @@ static void dram_enable(struct device *dev)
/* The Address Next to the Last Valid DRAM Address */ /* The Address Next to the Last Valid DRAM Address */
pci_write_config16(dev, 0x88, reg | mregs.shadow_mem_ctrl); pci_write_config16(dev, 0x88, reg | mregs.shadow_mem_ctrl);
print_debug(" VIA_X_3 device dump:\n"); printk(BIOS_DEBUG, " VIA_X_3 device dump:\n");
dump_south(dev); dump_south(dev);
} }

25
src/southbridge/via/k8t890/early_car.c
View File

@ -80,23 +80,23 @@ u8 k8t890_early_setup_ht(void)
} }
#if CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8M800 #if CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8M800
print_debug("K8M800 found at LDT "); printk(BIOS_DEBUG, "K8M800 found at LDT ");
#elif CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8T800 #elif CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8T800
print_debug("K8T800 found at LDT "); printk(BIOS_DEBUG, "K8T800 found at LDT ");
#elif CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8T800_OLD #elif CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8T800_OLD
print_debug("K8T800_OLD found at LDT "); printk(BIOS_DEBUG, "K8T800_OLD found at LDT ");
pci_write_config8(PCI_DEV(0, 0x0, 0), 0x64, 0x00); pci_write_config8(PCI_DEV(0, 0x0, 0), 0x64, 0x00);
pci_write_config8(PCI_DEV(0, 0x0, 0), 0xdd, 0x50); pci_write_config8(PCI_DEV(0, 0x0, 0), 0xdd, 0x50);
#elif CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8T800PRO #elif CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8T800PRO
print_debug("K8T800 Pro found at LDT "); printk(BIOS_DEBUG, "K8T800 Pro found at LDT ");
#elif CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8M890 #elif CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8M890
print_debug("K8M890 found at LDT "); printk(BIOS_DEBUG, "K8M890 found at LDT ");
/* K8M890 fix HT delay */ /* K8M890 fix HT delay */
pci_write_config8(PCI_DEV(0, 0x0, 2), 0xab, 0x22); pci_write_config8(PCI_DEV(0, 0x0, 2), 0xab, 0x22);
#elif CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8T890 #elif CONFIG_SOUTHBRIDGE_VIA_SUBTYPE_K8T890
print_debug("K8T890 found at LDT "); printk(BIOS_DEBUG, "K8T890 found at LDT ");
#endif #endif
print_debug_hex8(ldtnr); printk(BIOS_DEBUG, "%02x", ldtnr);
/* get the maximum widths for both sides */ /* get the maximum widths for both sides */
cldtwidth_in = pci_read_config8(PCI_DEV(0, 0x18, 0), ldtreg[ldtnr]) & 0x7; cldtwidth_in = pci_read_config8(PCI_DEV(0, 0x18, 0), ldtreg[ldtnr]) & 0x7;
@ -105,8 +105,7 @@ u8 k8t890_early_setup_ht(void)
vldtwidth_out = (pci_read_config8(PCI_DEV(0, 0x0, 0), K8X8XX_HT_CFG_BASE + 0x6) >> 4) & 0x7; vldtwidth_out = (pci_read_config8(PCI_DEV(0, 0x0, 0), K8X8XX_HT_CFG_BASE + 0x6) >> 4) & 0x7;
width = MIN(MIN(MIN(cldtwidth_out, cldtwidth_in), vldtwidth_out), vldtwidth_in); width = MIN(MIN(MIN(cldtwidth_out, cldtwidth_in), vldtwidth_out), vldtwidth_in);
print_debug(" Agreed on width: "); printk(BIOS_DEBUG, " Agreed on width: %02x", width);
print_debug_hex8(width);
awidth = pci_read_config8(PCI_DEV(0, 0x0, 0), K8X8XX_HT_CFG_BASE + 0x7); awidth = pci_read_config8(PCI_DEV(0, 0x0, 0), K8X8XX_HT_CFG_BASE + 0x7);
@ -117,12 +116,10 @@ u8 k8t890_early_setup_ht(void)
/* Get programmed HT freq at base 0x89 */ /* Get programmed HT freq at base 0x89 */
cldtfreq = pci_read_config8(PCI_DEV(0, 0x18, 0), ldtreg[ldtnr] + 3) & 0xf; cldtfreq = pci_read_config8(PCI_DEV(0, 0x18, 0), ldtreg[ldtnr] + 3) & 0xf;
print_debug(" CPU programmed to HT freq: "); printk(BIOS_DEBUG, " CPU programmed to HT freq: %02x", cldtfreq);
print_debug_hex8(cldtfreq);
print_debug(" VIA HT caps: ");
vldtcaps = pci_read_config16(PCI_DEV(0, 0, 0), K8X8XX_HT_CFG_BASE + 0xe); vldtcaps = pci_read_config16(PCI_DEV(0, 0, 0), K8X8XX_HT_CFG_BASE + 0xe);
print_debug_hex16(vldtcaps); printk(BIOS_DEBUG, " VIA HT caps: %04x", vldtcaps);
if (!(vldtcaps & (1 << cldtfreq ))) { if (!(vldtcaps & (1 << cldtfreq ))) {
die("Chipset does not support desired HT frequency\n"); die("Chipset does not support desired HT frequency\n");
@ -130,7 +127,7 @@ u8 k8t890_early_setup_ht(void)
afreq = pci_read_config8(PCI_DEV(0, 0x0, 0), K8X8XX_HT_CFG_BASE + 0xd); afreq = pci_read_config8(PCI_DEV(0, 0x0, 0), K8X8XX_HT_CFG_BASE + 0xd);
pci_write_config8(PCI_DEV(0, 0x0, 0), K8X8XX_HT_CFG_BASE + 0xd, cldtfreq); pci_write_config8(PCI_DEV(0, 0x0, 0), K8X8XX_HT_CFG_BASE + 0xd, cldtfreq);
print_debug("\n"); printk(BIOS_DEBUG, "\n");
/* no reset needed */ /* no reset needed */
if ((width == awidth) && (afreq == cldtfreq)) { if ((width == awidth) && (afreq == cldtfreq)) {

6
src/southbridge/via/k8t890/error.c
View File

@ -26,7 +26,7 @@
static void error_enable(struct device *dev) static void error_enable(struct device *dev)
{ {
print_debug(" K8x8xx: Enabling NB error reporting: "); printk(BIOS_DEBUG, " K8x8xx: Enabling NB error reporting: ");
/* /*
* bit0 - Enable V-link parity error reporting in 0x50 bit0 (RWC) * bit0 - Enable V-link parity error reporting in 0x50 bit0 (RWC)
* bit6 - Parity Error/SERR# Report Through V-Link to SB * bit6 - Parity Error/SERR# Report Through V-Link to SB
@ -34,10 +34,10 @@ static void error_enable(struct device *dev)
*/ */
pci_write_config8(dev, 0x58, 0x81); pci_write_config8(dev, 0x58, 0x81);
print_debug("Done\n"); printk(BIOS_DEBUG, "Done\n");
/* TODO: enable AGP errors reporting on K8M890 */ /* TODO: enable AGP errors reporting on K8M890 */
print_debug(" VIA_X_1 device dump:\n"); printk(BIOS_DEBUG, " VIA_X_1 device dump:\n");
dump_south(dev); dump_south(dev);
} }

2
src/southbridge/via/k8t890/host.c
View File

@ -60,7 +60,7 @@ static void host_enable(struct device *dev)
/* Multiple function control */ /* Multiple function control */
pci_write_config8(dev, K8T890_MULTIPLE_FN_EN, 0x01); pci_write_config8(dev, K8T890_MULTIPLE_FN_EN, 0x01);
print_debug(" VIA_X_0 device dump:\n"); printk(BIOS_DEBUG, " VIA_X_0 device dump:\n");
dump_south(dev); dump_south(dev);
} }

2
src/southbridge/via/k8t890/host_ctrl.c
View File

@ -84,7 +84,7 @@ static void host_ctrl_enable_k8t8xx(struct device *dev)
writeback(dev, 0xc4, 0x50); writeback(dev, 0xc4, 0x50);
writeback(dev, 0xc5, 0x50); writeback(dev, 0xc5, 0x50);
print_debug(" VIA_X_2 device dump:\n"); printk(BIOS_DEBUG, " VIA_X_2 device dump:\n");
dump_south(dev); dump_south(dev);
} }

4
src/southbridge/via/vt8237r/ctrl.c
View File

@ -130,7 +130,7 @@ static void vt8237s_vlink_init(struct device *dev)
/* No pairing NB was found. */ /* No pairing NB was found. */
if (!devfun7) if (!devfun7)
{ {
print_debug("vt8237s_vlink_init: No pairing NB was found.\n"); printk(BIOS_DEBUG, "vt8237s_vlink_init: No pairing NB was found.\n");
return; return;
} }
@ -205,7 +205,7 @@ static void vt8237a_vlink_init(struct device *dev)
/* No pairing NB was found. */ /* No pairing NB was found. */
if (!devfun7) if (!devfun7)
{ {
print_debug("vt8237a_vlink_init: No pairing NB was found.\n"); printk(BIOS_DEBUG, "vt8237a_vlink_init: No pairing NB was found.\n");
return; return;
} }

26
src/southbridge/via/vt8237r/early_smbus.c
View File

@ -42,17 +42,17 @@ static void smbus_print_error(u8 host_status, int loops)
return; return;
if (loops >= SMBUS_TIMEOUT) if (loops >= SMBUS_TIMEOUT)
print_err("SMBus timeout\n"); printk(BIOS_ERR, "SMBus timeout\n");
if (host_status & (1 << 4)) if (host_status & (1 << 4))
print_err("Interrupt/SMI# was Failed Bus Transaction\n"); printk(BIOS_ERR, "Interrupt/SMI# was Failed Bus Transaction\n");
if (host_status & (1 << 3)) if (host_status & (1 << 3))
print_err("Bus error\n"); printk(BIOS_ERR, "Bus error\n");
if (host_status & (1 << 2)) if (host_status & (1 << 2))
print_err("Device error\n"); printk(BIOS_ERR, "Device error\n");
if (host_status & (1 << 1)) if (host_status & (1 << 1))
print_debug("Interrupt/SMI# completed successfully\n"); printk(BIOS_DEBUG, "Interrupt/SMI# completed successfully\n");
if (host_status & (1 << 0)) if (host_status & (1 << 0))
print_err("Host busy\n"); printk(BIOS_ERR, "Host busy\n");
} }
/** /**
@ -229,7 +229,7 @@ void smbus_fixup(const struct mem_controller *ctrl)
ram_slots = ARRAY_SIZE(ctrl->channel0); ram_slots = ARRAY_SIZE(ctrl->channel0);
if (!ram_slots) { if (!ram_slots) {
print_err("smbus_fixup() thinks there are no RAM slots!\n"); printk(BIOS_ERR, "smbus_fixup() thinks there are no RAM slots!\n");
return; return;
} }
@ -253,7 +253,7 @@ void smbus_fixup(const struct mem_controller *ctrl)
} }
if (i >= SMBUS_TIMEOUT) if (i >= SMBUS_TIMEOUT)
print_err("SMBus timed out while warming up\n"); printk(BIOS_ERR, "SMBus timed out while warming up\n");
else else
PRINT_DEBUG("Done\n"); PRINT_DEBUG("Done\n");
} }
@ -336,7 +336,7 @@ int acpi_is_wakeup_early(void)
device_t dev; device_t dev;
u16 tmp; u16 tmp;
print_debug("IN TEST WAKEUP\n"); printk(BIOS_DEBUG, "IN TEST WAKEUP\n");
/* Power management controller */ /* Power management controller */
dev = get_vt8237_lpc(); dev = get_vt8237_lpc();
@ -351,7 +351,7 @@ int acpi_is_wakeup_early(void)
tmp = inw(VT8237R_ACPI_IO_BASE + 0x04); tmp = inw(VT8237R_ACPI_IO_BASE + 0x04);
print_debug_hex8(tmp); printk(BIOS_DEBUG, "%02x", tmp);
return ((tmp & (7 << 10)) >> 10) == 1 ? 3 : 0 ; return ((tmp & (7 << 10)) >> 10) == 1 ? 3 : 0 ;
} }
#endif #endif
@ -426,7 +426,7 @@ int vt8237_early_network_init(struct vt8237_network_rom *rom)
dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_VIA, dev = pci_locate_device(PCI_ID(PCI_VENDOR_ID_VIA,
PCI_DEVICE_ID_VIA_8233_7), 0); PCI_DEVICE_ID_VIA_8233_7), 0);
if (dev == PCI_DEV_INVALID) { if (dev == PCI_DEV_INVALID) {
print_err("Network is disabled, please enable\n"); printk(BIOS_ERR, "Network is disabled, please enable\n");
return 0; return 0;
} }
@ -441,7 +441,7 @@ int vt8237_early_network_init(struct vt8237_network_rom *rom)
return 0; return 0;
if (rom == NULL) { if (rom == NULL) {
print_err("No config data specified, using default MAC!\n"); printk(BIOS_ERR, "No config data specified, using default MAC!\n");
n.mac_address[0] = 0x0; n.mac_address[0] = 0x0;
n.mac_address[1] = 0x0; n.mac_address[1] = 0x0;
n.mac_address[2] = 0xde; n.mac_address[2] = 0xde;
@ -503,7 +503,7 @@ int vt8237_early_network_init(struct vt8237_network_rom *rom)
} }
if (loops >= LAN_TIMEOUT) { if (loops >= LAN_TIMEOUT) {
print_err("Timeout - LAN controller didn't accept config\n"); printk(BIOS_ERR, "Timeout - LAN controller didn't accept config\n");
return 0; return 0;
} }

10
src/southbridge/via/vt8237r/vt8237r.c
View File

@ -37,13 +37,9 @@ void writeback(struct device *dev, u16 where, u8 what)
pci_write_config8(dev, where, what); pci_write_config8(dev, where, what);
regval = pci_read_config8(dev, where); regval = pci_read_config8(dev, where);
if (regval != what) { if (regval != what)
print_debug("Writeback to "); printk(BIOS_DEBUG, "Writeback to %02x failed %02x\n",
print_debug_hex8(where); where, regval);
print_debug(" failed ");
print_debug_hex8(regval);
print_debug("\n");
}
} }
#else #else
void writeback(struct device *dev, u16 where, u8 what) void writeback(struct device *dev, u16 where, u8 what)

4
src/southbridge/via/vt8237r/vt8237r.h
View File

@ -94,8 +94,8 @@
#define CLOCK_SLAVE_ADDRESS 0x69 #define CLOCK_SLAVE_ADDRESS 0x69
#if CONFIG_DEBUG_SMBUS #if CONFIG_DEBUG_SMBUS
#define PRINT_DEBUG(x) print_debug(x) #define PRINT_DEBUG(x) printk(BIOS_DEBUG, x)
#define PRINT_DEBUG_HEX16(x) print_debug_hex16(x) #define PRINT_DEBUG_HEX16(x) printk(BIOS_DEBUG, "%04x", x)
#else #else
#define PRINT_DEBUG(x) #define PRINT_DEBUG(x)
#define PRINT_DEBUG_HEX16(x) #define PRINT_DEBUG_HEX16(x)